Configuration option for HTTP request header redaction. #15353
Conversation
…equest headers to be redacted
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
1 similar comment
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
ucosty
changed the title
|
Thanks for your contribution! It looks fine to me, pending CI. Can you also add an entry in |
|
@adriansr I've updated the next changelog, as well as the asciidoc as per your request. |
| import os | ||
| import sys | ||
| import subprocess | ||
| import json | ||
|
|
||
| sys.path.append(os.path.join(os.path.dirname(__file__), '../../../libbeat/tests/system')) | ||
|
|
||
| from beat.beat import TestCase | ||
| from beat.beat import Proc |
There was a problem hiding this comment.
Can you revert this change? It is causing the tests to fail because its looking for beat.beat on the wrong path.
There was a problem hiding this comment.
All done, and it looks like that build stage is passing now.
|
Pinging @elastic/siem (Team:SIEM) |
|
jenkins, test this |
Co-Authored-By: Adrian Serrano <adrisr83@gmail.com>
|
jenkins, test this |
adriansr
added
the
needs_backport
|
@adriansr do you know when this feature might make a release? It doesn't seem to be included in any of the releases since the merge to master. |
|
@ucosty no, it was too late for 7.6.0, but I will backport it so its released in 7.7.0 |
Add redact_headers configuration option, which allows specific HTTP request headers to be redacted. I've run into situations where people have added things like API keys into HTTP headers, which are making their way into our logs. (cherry picked from commit ddeeb02)
adriansr
added
v7.7.0
and removed
needs_backport
…er redaction. (#17107) * Configuration option for HTTP request header redaction. (#15353) Add redact_headers configuration option, which allows specific HTTP request headers to be redacted. I've run into situations where people have added things like API keys into HTTP headers, which are making their way into our logs. (cherry picked from commit ddeeb02) * Fix changelog Co-authored-by: Matthew Costa <ucosty@users.noreply.github.com>
Add redact_headers configuration option, which allows specific HTTP request headers to be redacted.
I've run into situations where people have added things like API keys into HTTP headers, which are making their way into our logs.