Cherry-pick #14875 to 7.x: Refactor metadata generator to support adding metadata across resources #15528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es (elastic#14875) * Refactor metagen to allow multiple resources to be enriched (cherry picked from commit dba8f74)
houndci-bot
reviewed
Jan 14, 2020
| } | ||
|
|
||
| return n.Generate(no, opts...) | ||
| } else { |
There was a problem hiding this comment.
if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
houndci-bot
reviewed
Jan 14, 2020
| } | ||
|
|
||
| return n.Generate(no, opts...) | ||
| } else { |
There was a problem hiding this comment.
if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
houndci-bot
reviewed
Jan 14, 2020
| } | ||
|
|
||
| return n.Generate(no, opts...) | ||
| } else { |
There was a problem hiding this comment.
if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
odacremolbap
approved these changes
Jan 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #14875 to 7.x branch. Original message:
This PR attempts to refactor metadata generator to support enrichment of resources metadata on top of other resources.
Ex: enriching a pod object with information from a node and namespace object.
This PR does the same only for the autodiscover provider of kubernetes. It adds a configuration
add_resource_metadatato allow specifying what resources should be used for enrichment.Sample configuration:
this would ensure that we additionally add namespace metadata along with the service metadata.
pods can be enriched with node and namespace metadata. the
namespaceandnodeparameters ofadd_resource_metadatacan takeinclude_*,exlude_*configs similar to the parent resource.closes #13873