Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #15511 to 7.x: Fix pull on ContainerStart wrapper used in tests #15537

Merged
merged 1 commit into from
Jan 14, 2020
Merged

Cherry-pick #15511 to 7.x: Fix pull on ContainerStart wrapper used in tests #15537

merged 1 commit into from
Jan 14, 2020

Commits on Jan 14, 2020

  1. Fix pull on ContainerStart wrapper used in tests (elastic#15511) 

    ContainerStart wrapper used in tests was not waiting for the pull to
finish, causing flakiness, e.g. in TestDockerStart. Pull can be
waited to finish by calling to Close() in the response body. This is
also something that has to be done at some moment to avoid leaks.

Also add some more context on error messages.

(cherry picked from commit dd553b3)
    @jsoriano
    jsoriano committed Jan 14, 2020
    Configuration menu
    Copy the full SHA
    c2d81fc View commit details
    Browse the repository at this point in the history