Exclude TLS1.3 support if older go version is used #15543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only compile with TLS1.3 support for go1.13 or newer is used. If an older go version is used we stick with TLS1.2 max. The change also introduces TLSVersionMin/Max and TLSVersionDefaultMin/Max constants, so to keep the tests intact.
houndci-bot
reviewed
Jan 14, 2020
| import "crypto/tls" | ||
|
|
||
| const ( | ||
| TLSVersionSSL30 TLSVersion = tls.VersionSSL30 |
There was a problem hiding this comment.
exported const TLSVersionSSL30 should have comment (or a comment on this block) or be unexported
kvch
approved these changes
Jan 14, 2020
faec
approved these changes
Jan 14, 2020
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
Only compile with TLS1.3 support for go1.13 or newer is used. If an older go version is used we stick with TLS1.2 max. The change also introduces TLSVersionMin/Max and TLSVersionDefaultMin/Max constants, so to keep the tests intact.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only compile with TLS1.3 support for go1.13 or newer is used. If an
older go version is used we stick with TLS1.2 max.
The change also introduces TLSVersionMin/Max and
TLSVersionDefaultMin/Max constants, so to keep the tests intact.
Note: This change comes with a gotcha. All TLS documentation use the same contents and will mention TLS1.3. But GCP support will not have TLS1.3 support, because GCP requires go1.11. This must be reflected in our GCP Functionbeat docs as well.