Cherry-pick #15686 to 7.x: Remove datasource option from SQL module and add tests #15697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove datasource option from SQL module. This option was intended to set the DSN of a database connection, and we were ignoring the hosts setting. In other SQL modules we are using the values in hosts as DSNs, do here the same for consistency. Host is redacted when we cannot parse it as it can contain passwords. StandardizeEvent is exposed in mbtest.Fetcher interface so we can more easily check contents of events in tests. Add integration tests of the module with MySQL and PostgreSQL. Add real data.json with data from MySQL and PostgreSQL. (cherry picked from commit 8c71abc)
kaiyan-sheng
approved these changes
Jan 21, 2020
Yep, this is a change in an unreleased feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #15686 to 7.x branch. Original message:
What does this PR do?
datasourceoption from SQL module. This option was intended to set the DSN of a database connection, and we were ignoring thehostssetting. In other SQL modules we are using the values inhostas DSNs, do here the same for consistency. Host is redacted when we cannot parse it as it can contain passwords.StandardizeEventis exposed inmbtest.Fetcherinterface so we can more easily check contents of events.data.jsonwith data from MySQL and PostgreSQL.Why is it important?
Checklist
Related issues