-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue where default go logger is not discarded when either * or stdout is selected. #15708
Conversation
@ph @andrewkroh Can you have a look, please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, looked through the previous issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I'm understanding the original issue correctly I think another change is needed.
I need to check my zube rules for this, i've missed you initial ping @blakerouse |
Based on @andrewkroh comment I need to remove it.
… is selected. Add more tests.
@andrewkroh @ph Adjusted the code based on the review, if you could give this another look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. It's missing a changelog entry.
What does this PR do?
Fix issue where default go logger is not discarded when either * or stdout is selected.
Why is it important?
Prevents other imported modules from outputting log messages.
Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration filesRelated issues