[Metricbeat][Istio] Add pilot metricset #15761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ioannis Androulidakis <ioannis@arrikto.com>
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
1 similar comment
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
ChrsMark
reviewed
Jan 23, 2020
ChrsMark
added
Team:Integrations
11 tasks
andresrc
changed the title
andresrc
added
[zube]: Inbox
[zube]: In Review
and removed
[zube]: In Review
[zube]: Inbox
labels
Signed-off-by: Ioannis Androulidakis <ioannis@arrikto.com>
|
Thanks for the changes @ioandr ! It looks like a Also please update the expected golden file https://github.com/elastic/beats/pull/15761/files#diff-1358955e525da296ba2ccdc472ebbb06 and |
Signed-off-by: Ioannis Androulidakis <ioannis@arrikto.com>
Signed-off-by: Ioannis Androulidakis <ioannis@arrikto.com>
|
ok to test |
ChrsMark
approved these changes
Jan 29, 2020
Signed-off-by: Ioannis Androulidakis <ioannis@arrikto.com>
ioandr
force-pushed
the
feature-metricbeat-istio-pilot
branch
from
b79f604
to
2457e5f
Compare
Signed-off-by: Ioannis Androulidakis <ioannis@arrikto.com>
ioandr
force-pushed
the
feature-metricbeat-istio-pilot
branch
from
2457e5f
to
f560ff2
Compare
ChrsMark
added
the
needs_backport
ChrsMark
pushed a commit
to ChrsMark/beats
that referenced
this pull request
Feb 4, 2020
(cherry picked from commit 238cc7d)
ChrsMark
removed
the
needs_backport
ChrsMark
added a commit
that referenced
this pull request
Feb 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add pilot metricset for istio Module.
The metrics are collected and exposed by a Prometheus exporter at endpoint:
istio-pilot.istio-system:15014The pilot job returns the Pilot-generated metrics.
Why is it important?
To enhance the ISTIO module and provide an all-around perspective of it.
How to test this PR locally
metricbeatexecutableistio-pilot.istio-systemservice to working machine, usingkubectl port-forwardistiomodule, configure it inmetricbeat.yamland start monitoring ISTIO pilotRelated issues