Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kubernetes: update replicaset type to apps/v1 #15854

Merged
merged 2 commits into from
Jan 27, 2020
Merged

Kubernetes: update replicaset type to apps/v1 #15854

merged 2 commits into from
Jan 27, 2020

Conversation

odacremolbap
Copy link
Contributor

Since kubernetes 1.16 replicasets needs to be create from apps/v1 group.

@odacremolbap odacremolbap added Team:Integrations Label for the Integrations team containers Related to containers use case labels Jan 27, 2020
ChrsMark
ChrsMark approved these changes Jan 27, 2020
View reviewed changes
Copy link
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change LGTM.

Just a question, is it documented how the different versions are supported, backwards compatibility etc?

@andresrc andresrc added [zube]: Inbox Team:Platforms Label for the Integrations - Platforms team [zube]: In Review and removed [zube]: Inbox labels Jan 27, 2020
@odacremolbap odacremolbap merged commit 89822fe into elastic:master Jan 27, 2020
@odacremolbap odacremolbap added the needs_backport PR is waiting to be backported to other branches. label Jan 27, 2020
odacremolbap pushed a commit to odacremolbap/beats that referenced this pull request Jan 27, 2020
@odacremolbap
Kubernetes: update replicaset type to apps/v1 (elastic#15854)
89f9cce 
* update replicaset type to apps/v1

(cherry picked from commit 89822fe)
@odacremolbap odacremolbap mentioned this pull request Jan 27, 2020
Merged
@odacremolbap odacremolbap added v7.6.0 and removed needs_backport PR is waiting to be backported to other branches. labels Jan 27, 2020
odacremolbap pushed a commit that referenced this pull request Jan 28, 2020
Cherry-pick #15854 to 7.x: Kubernetes: update replicaset type to apps…
f1e6956 
…/v1 (#15869)

* Kubernetes: update replicaset type to apps/v1 (#15854)

* update replicaset type to apps/v1

(cherry picked from commit 89822fe)

* remove changelog not backported
@immon
Copy link
Contributor

immon commented Jan 31, 2020

@odacremolbap is it going to be included in 7.6?
I do not find this fix in 7.6 branch https://github.com/elastic/beats/blob/7.6/libbeat/common/kubernetes/types.go#L68

@odacremolbap odacremolbap mentioned this pull request Feb 3, 2020
Merged
odacremolbap pushed a commit to odacremolbap/beats that referenced this pull request Feb 3, 2020
@odacremolbap
Kubernetes: update replicaset type to apps/v1 (elastic#15854)
a423957 
* update replicaset type to apps/v1

(cherry picked from commit 89822fe)
@odacremolbap odacremolbap deleted the fix/replicaset-appsv1 branch February 3, 2020 12:16
odacremolbap pushed a commit that referenced this pull request Feb 3, 2020
Kubernetes: update replicaset type to apps/v1 (#15854) (#16018)
e3a7c9c 
* update replicaset type to apps/v1

(cherry picked from commit 89822fe)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrsMark ChrsMark ChrsMark approved these changes

Assignees
No one assigned
Labels
containers Related to containers use case Team:Integrations Label for the Integrations team Team:Platforms Label for the Integrations - Platforms team v7.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@odacremolbap @immon @ChrsMark @andresrc