[Elastic Log Driver] Fix file check bug, deal with logging #15935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fearful-symmetry
added
bug
needs_backport
jsoriano
approved these changes
Jan 29, 2020
| @@ -26,8 +26,12 @@ import ( | |||
|
|
|||
| // genNewMonitoringConfig is a hacked-in function to enable a debug stderr logger | |||
| func genNewMonitoringConfig() (*common.Config, error) { | |||
| lvl, isSet := os.LookupEnv("LOG_DRIVER_LEVEL") | |||
There was a problem hiding this comment.
no need to change 😬 maybe logDriverLevel or ldl is better?
kaiyan-sheng
approved these changes
Jan 29, 2020
kaiyan-sheng
approved these changes
Jan 30, 2020
|
run beats-ci/package |
jsoriano
approved these changes
Jan 30, 2020
|
run beats-ci/package |
|
run beats-ci/package |
1 similar comment
|
run beats-ci/package |
fearful-symmetry
removed
the
needs_backport
fearful-symmetry
added a commit
to fearful-symmetry/beats
that referenced
this pull request
Feb 5, 2020
fearful-symmetry
added a commit
to fearful-symmetry/beats
that referenced
this pull request
Feb 5, 2020
fearful-symmetry
added a commit
that referenced
this pull request
Feb 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses a bug where we weren't properly checking to see if a
meta.jsonfile existed, and also a default debug log level. Users can now config the log level withLOG_DRIVER_LEVEL