Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Kafka README for manual testing #15955

Merged
merged 3 commits into from
Feb 4, 2020
Merged

Add Kafka README for manual testing #15955

merged 3 commits into from
Feb 4, 2020

Conversation

ChrsMark
Copy link
Member

@ChrsMark ChrsMark commented Jan 30, 2020 •
edited
Loading

What does this PR do?

This PR adds docs on how to manual test Kafka Module locally.

Why is it important?

Bringing up a Kafka instance and having Kafka Module successfully connected to it's broker can be tricky. These docs provide a fast way to go with.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works

Related issues

@sayden @jsoriano @faec feel free to comment/suggest anything!

@ChrsMark
Add Kafka README for manual testing
5c0fccb 
Signed-off-by: chrismark <chrismarkou92@gmail.com>
@ChrsMark ChrsMark added enhancement docs review [zube]: In Review Team:Integrations Label for the Integrations team Team:Services (Deprecated) Label for the former Integrations-Services team labels Jan 30, 2020
@ChrsMark ChrsMark requested a review from a team January 30, 2020 10:07
@ChrsMark ChrsMark self-assigned this Jan 30, 2020
jsoriano
jsoriano approved these changes Jan 30, 2020
View reviewed changes
Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

metricbeat/module/kafka/README.md Show resolved Hide resolved
@ChrsMark
Add extra note
cbd164f 
Signed-off-by: chrismark <chrismarkou92@gmail.com>
jsoriano
jsoriano approved these changes Jan 30, 2020
View reviewed changes
metricbeat/module/kafka/README.md Outdated Show resolved Hide resolved
@ChrsMark @jsoriano
Update metricbeat/module/kafka/README.md
c86a013 
Co-Authored-By: Jaime Soriano Pastor <jaime.soriano@elastic.co>
@ChrsMark ChrsMark merged commit c57b8b8 into elastic:master Feb 4, 2020
ChrsMark added a commit to ChrsMark/beats that referenced this pull request Feb 4, 2020
@ChrsMark
Add Kafka README for manual testing (elastic#15955)
5bbdb7c 
(cherry picked from commit c57b8b8)
@ChrsMark ChrsMark mentioned this pull request Feb 4, 2020
Merged
5 tasks
@ChrsMark ChrsMark added the v7.7.0 label Feb 4, 2020
ChrsMark added a commit that referenced this pull request Feb 4, 2020
@ChrsMark
Add Kafka README for manual testing (#15955) (#16053)
14ea1ab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsoriano jsoriano jsoriano approved these changes

Assignees

@ChrsMark ChrsMark

Labels
docs enhancement review Team:Integrations Label for the Integrations team Team:Services (Deprecated) Label for the former Integrations-Services team v7.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChrsMark @jsoriano @andresrc