Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Filebeat] Add ECS tls fields to zeek and aws modules (#15936) #16043

Merged
merged 2 commits into from
Feb 5, 2020

Conversation

leehinman
Copy link
Contributor

  • Add ECS tls fields to zeek and aws modules
  • zeek/smtp
    • tls.established
  • zeek/rdp
    • tls.established
  • zeek/ssl
    • tls.cipher
    • tls.curve
    • tls.client.issuer
    • tls.established
    • tls.resumed
    • tls.server.issuer
    • tls.version
    • tls.version_protocol
  • aws/elb
    • tls.cipher
    • tls.version
    • tls.version_protocol
  • aws/s3access
    • tls.cipher
    • tls.version
    • tls.version_protocol

Closes #15757

(cherry picked from commit b6baae0)

What does this PR do?

Why is it important?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

* Add ECS tls fields to zeek and aws modules

- zeek/smtp
  + tls.established
- zeek/rdp
  + tls.established
- zeek/ssl
  + tls.cipher
  + tls.curve
  + tls.client.issuer
  + tls.established
  + tls.resumed
  + tls.server.issuer
  + tls.version
  + tls.version_protocol
- aws/elb
  + tls.cipher
  + tls.version
  + tls.version_protocol
- aws/s3access
  + tls.cipher
  + tls.version
  + tls.version_protocol

Closes elastic#15757

(cherry picked from commit b6baae0)
@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leehinman leehinman merged commit 064f4ee into elastic:7.x Feb 5, 2020
@leehinman leehinman deleted the backport_15936_7.x branch February 5, 2020 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants