Add dependencies with v2 or bigger major versions #16100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvch
added
[zube]: In Progress
Team:Services
kvch
force-pushed
the
find-correct-major-versions
branch
from
3cfd6b6 to
1cdbace
Compare
jsoriano
approved these changes
Feb 6, 2020
| @@ -22,7 +22,7 @@ package instance | |||
| import ( | |||
| "fmt" | |||
|
|
|||
| "github.com/coreos/go-systemd/sdjournal" | |||
| "github.com/coreos/go-systemd/v22/sdjournal" | |||
There was a problem hiding this comment.
Is go-systemd changing the import path on any release? It seems rather inconvenient.
There was a problem hiding this comment.
It is going to be inconvenient for us every time we update a major release with go modules. At least they are adopting the modules approach, not like a few of our dependencies. :)
kvch
force-pushed
the
find-correct-major-versions
branch
from
1cdbace to
3215e84
Compare
kvch
force-pushed
the
find-correct-major-versions
branch
from
3215e84 to
91445e8
Compare
urso
reviewed
Feb 6, 2020
| @@ -15,7 +15,7 @@ import ( | |||
| "strconv" | |||
| "time" | |||
|
|
|||
| "github.com/cespare/xxhash" | |||
| xxhash "github.com/cespare/xxhash/v2" | |||
There was a problem hiding this comment.
is the "rename" of v2 to xxhash required? Is it added by automation? If a package only imports vX I think one can ommit the renaming part.
There was a problem hiding this comment.
No. For some reason goimports kept removing the line until I added the alias. But now I am able to remove it. So I assume it was some kind of PEBKAC. So I removed thos now.
urso
approved these changes
Feb 6, 2020
|
No new errors has been introduced, merging. |
kvch
added a commit
that referenced
this pull request
Feb 26, 2020
## What does this PR do? The PR adds the major version to the import paths of modules which have major versions bigger than one. The following modules are impacted: - `github.com/coreos/go-systemd` is updated to use `v22` - `github.com/cespare/xxhash` is updated to use `v2` ## Why is it important? We have a few dependencies with a major version bigger than v1. These modules include the major version in the import path. In order to include the correct dependencies, one needs to add the major version of the module to `go.mod`. Keep in mind that every time we update a dependency to a newer major version, we need to follow-up in the import paths in our source.
kvch
added a commit
that referenced
this pull request
Feb 27, 2020
## What does this PR do? The PR adds the major version to the import paths of modules which have major versions bigger than one. The following modules are impacted: - `github.com/coreos/go-systemd` is updated to use `v22` - `github.com/cespare/xxhash` is updated to use `v2` ## Why is it important? We have a few dependencies with a major version bigger than v1. These modules include the major version in the import path. In order to include the correct dependencies, one needs to add the major version of the module to `go.mod`. Keep in mind that every time we update a dependency to a newer major version, we need to follow-up in the import paths in our source.
kvch
added a commit
that referenced
this pull request
Feb 28, 2020
## What does this PR do? The PR adds the major version to the import paths of modules which have major versions bigger than one. The following modules are impacted: - `github.com/coreos/go-systemd` is updated to use `v22` - `github.com/cespare/xxhash` is updated to use `v2` ## Why is it important? We have a few dependencies with a major version bigger than v1. These modules include the major version in the import path. In order to include the correct dependencies, one needs to add the major version of the module to `go.mod`. Keep in mind that every time we update a dependency to a newer major version, we need to follow-up in the import paths in our source.
kvch
added a commit
that referenced
this pull request
Mar 2, 2020
## What does this PR do? The PR adds the major version to the import paths of modules which have major versions bigger than one. The following modules are impacted: - `github.com/coreos/go-systemd` is updated to use `v22` - `github.com/cespare/xxhash` is updated to use `v2` ## Why is it important? We have a few dependencies with a major version bigger than v1. These modules include the major version in the import path. In order to include the correct dependencies, one needs to add the major version of the module to `go.mod`. Keep in mind that every time we update a dependency to a newer major version, we need to follow-up in the import paths in our source.
kvch
added a commit
that referenced
this pull request
Mar 3, 2020
## What does this PR do? The PR adds the major version to the import paths of modules which have major versions bigger than one. The following modules are impacted: - `github.com/coreos/go-systemd` is updated to use `v22` - `github.com/cespare/xxhash` is updated to use `v2` ## Why is it important? We have a few dependencies with a major version bigger than v1. These modules include the major version in the import path. In order to include the correct dependencies, one needs to add the major version of the module to `go.mod`. Keep in mind that every time we update a dependency to a newer major version, we need to follow-up in the import paths in our source.
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
## What does this PR do? The PR adds the major version to the import paths of modules which have major versions bigger than one. The following modules are impacted: - `github.com/coreos/go-systemd` is updated to use `v22` - `github.com/cespare/xxhash` is updated to use `v2` ## Why is it important? We have a few dependencies with a major version bigger than v1. These modules include the major version in the import path. In order to include the correct dependencies, one needs to add the major version of the module to `go.mod`. Keep in mind that every time we update a dependency to a newer major version, we need to follow-up in the import paths in our source.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The PR adds the major version to the import paths of modules which have major versions bigger than one.
The following modules are impacted:
github.com/coreos/go-systemdis updated to usev22github.com/cespare/xxhashis updated to usev2Why is it important?
We have a few dependencies with a major version bigger than v1. These modules include the major version in the import path. In order to include the correct dependencies, one needs to add the major version of the module to
go.mod.Keep in mind that every time we update a dependency to a newer major version, we need to follow-up in the import paths in our source.
Checklist
- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have made the corresponding change to the default configuration files- [ ] I have added tests that prove my fix is effective or that my feature worksRelated issues