Reduce use of global loggers in libbeat/common #16149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urso
added
review
refactoring
libbeat
needs_backport
66 tasks
ycombinator
reviewed
Feb 6, 2020
ycombinator
approved these changes
Feb 6, 2020
ycombinator
approved these changes
Feb 7, 2020
kvch
approved these changes
Feb 7, 2020
urso
force-pushed
the
events-logp-methods
branch
from
7dbb2c2
to
df8989e
Compare
urso
force-pushed
the
events-logp-methods
branch
from
df8989e
to
87825e0
Compare
2 tasks
urso
added
v7.7.0
and removed
needs_backport
urso
pushed a commit
to urso/beats
that referenced
this pull request
Feb 19, 2020
* Reduce use of global loggers in libbeat/common * review (cherry picked from commit 3c78454)
urso
pushed a commit
that referenced
this pull request
Feb 19, 2020
* Reduce use of global loggers in libbeat/common * review (cherry picked from commit 3c78454)
kvch
pushed a commit
to kvch/beats
that referenced
this pull request
Feb 20, 2020
* Reduce use of global loggers in libbeat/common * review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Remove usage of logp.Debug/Warn by creating a logger instance in the GenericEventNormalizer. The
Normalizeruseslogp.Newfor now to keep the change less disruptive.Why is it important?
Getting rid of global loggers functions.
Checklist
- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration filesAuthor's Checklist
How to test this PR locally
Related issues