Omit monitoring object from logstash_stats.logstash object #16198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ycombinator
added
bug
Team:Integrations
|
Pinging @elastic/stack-monitoring (Stack monitoring) |
ycombinator
added
needs_backport
chrisronline
approved these changes
Feb 7, 2020
andresrc
added
[zube]: Inbox
[zube]: In Review
and removed
[zube]: In Review
[zube]: Inbox
labels
ycombinator
force-pushed
the
mb-ls-xp-parity
branch
from
59da7a2
to
cdbf46b
Compare
ChrsMark
approved these changes
Feb 11, 2020
ChrsMark
approved these changes
Feb 11, 2020
ycombinator
force-pushed
the
mb-ls-xp-parity
branch
from
39a97bd
to
127ea63
Compare
|
Travis CI is green and Jenkins CI failures are unrelated. Merging. |
ycombinator
removed
the
needs_backport
ycombinator
added a commit
that referenced
this pull request
Feb 19, 2020
kvch
pushed a commit
to kvch/beats
that referenced
this pull request
Feb 20, 2020
…6198) * Omit monitoring object from logstash_stats.logstash object * Removing unnecessary struct tag info * Adding CHANGELOG entry * Adding explanatory comment for nodeInfo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It removes a redundant field from Logstash monitoring data being indexed by Metricbeat for Stack Monitoring.
Why is it important?
It brings parity between Metricbeat collection and internal collection for Logstash monitoring data, specifically documents of
type:logstash_stats.Checklist
[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature worksThere are existing tests (stack monitoring parity tests) that are currently failing and should start passing once this PR is merged.How to test this PR locally
Install Logstash 7.6.0 or higher.
Configure Logstash to set the override cluster UUID. Edit
config/logstash.ymland setmonitoring.cluster_uuid: foobar.Build Metricbeat with this PR.
Enable the Logstash module for Stack Monitoring.
Run Metricbeat, outputting events to the Console so we can inspect them easily.
Check that events with
"type": "logstash_stats"or"type": "logstash_state"both have a top-level"cluster_uuid": "foobar"field in them.Also check that events with
"type": "logstash_stats"has a"logstash_stats.logstash"field which is an object. Check that this object does not contain a"monitoring"field.Related issues