Adjust CI configuration #16216
Merged
Adjust CI configuration #16216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ycombinator
reviewed
Feb 10, 2020
| @@ -32,7 +32,7 @@ $env:TEST_COVERAGE = "true" | |||
| $env:RACE_DETECTOR = "true" | |||
|
|
|||
| # Install mage from vendor. | |||
| exec { go install github.com/elastic/beats/vendor/github.com/magefile/mage } "mage install FAILURE" | |||
| exec { go install -mod=vendor github.com/magefile/mage } "mage install FAILURE" | |||
There was a problem hiding this comment.
Just for my understanding, this change is not really related to the _templates path change, right? It's just another change needed when moving to go modules?
ycombinator
approved these changes
Feb 10, 2020
There was a problem hiding this comment.
Template path changes LGTM, as a follow up to the changes made in #15688.
kvch
force-pushed
the
adjust-ci-config
branch
from
d10b2d0
to
f86e3d9
Compare
|
jenkins test this |
kvch
added a commit
that referenced
this pull request
Feb 26, 2020
## What does this PR do? This PR adjust the path of the generators as these have been moved. ## Why is it important? It has to be adjusted, otherwise the CI jobs cannot start.
kvch
added a commit
that referenced
this pull request
Feb 27, 2020
## What does this PR do? This PR adjust the path of the generators as these have been moved. ## Why is it important? It has to be adjusted, otherwise the CI jobs cannot start.
kvch
added a commit
that referenced
this pull request
Feb 28, 2020
## What does this PR do? This PR adjust the path of the generators as these have been moved. ## Why is it important? It has to be adjusted, otherwise the CI jobs cannot start.
kvch
added a commit
that referenced
this pull request
Mar 2, 2020
## What does this PR do? This PR adjust the path of the generators as these have been moved. ## Why is it important? It has to be adjusted, otherwise the CI jobs cannot start.
kvch
added a commit
that referenced
this pull request
Mar 3, 2020
## What does this PR do? This PR adjust the path of the generators as these have been moved. ## Why is it important? It has to be adjusted, otherwise the CI jobs cannot start.
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
## What does this PR do? This PR adjust the path of the generators as these have been moved. ## Why is it important? It has to be adjusted, otherwise the CI jobs cannot start.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adjust the path of the generators as these have been moved.
Why is it important?
It has to be adjusted, otherwise the CI jobs cannot start.
Checklist
- [ ] My code follows the style guidelines of this project- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added tests that prove my fix is effective or that my feature worksRequies #16127