dev-tools/mage: use "go list -m" to locate beats #16445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvch
approved these changes
Feb 24, 2020
Use the "go list" tool to locate the root directory of the elastic/beats module. This removes some assumptions about the use of vendoring, and hard-coded knowledge of the apm-server directory structure.
axw
force-pushed
the
golist-find-beats-dir
branch
from
038d6f5 to
c54875a
Compare
kvch
pushed a commit
that referenced
this pull request
Feb 26, 2020
* dev-tools/mage: use "go list -m" to locate beats Use the "go list" tool to locate the root directory of the elastic/beats module. This removes some assumptions about the use of vendoring, and hard-coded knowledge of the apm-server directory structure. * Account for versioned import paths
kvch
pushed a commit
that referenced
this pull request
Feb 27, 2020
* dev-tools/mage: use "go list -m" to locate beats Use the "go list" tool to locate the root directory of the elastic/beats module. This removes some assumptions about the use of vendoring, and hard-coded knowledge of the apm-server directory structure. * Account for versioned import paths
kvch
pushed a commit
that referenced
this pull request
Feb 28, 2020
* dev-tools/mage: use "go list -m" to locate beats Use the "go list" tool to locate the root directory of the elastic/beats module. This removes some assumptions about the use of vendoring, and hard-coded knowledge of the apm-server directory structure. * Account for versioned import paths
kvch
pushed a commit
that referenced
this pull request
Mar 2, 2020
* dev-tools/mage: use "go list -m" to locate beats Use the "go list" tool to locate the root directory of the elastic/beats module. This removes some assumptions about the use of vendoring, and hard-coded knowledge of the apm-server directory structure. * Account for versioned import paths
kvch
pushed a commit
that referenced
this pull request
Mar 3, 2020
* dev-tools/mage: use "go list -m" to locate beats Use the "go list" tool to locate the root directory of the elastic/beats module. This removes some assumptions about the use of vendoring, and hard-coded knowledge of the apm-server directory structure. * Account for versioned import paths
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
* dev-tools/mage: use "go list -m" to locate beats Use the "go list" tool to locate the root directory of the elastic/beats module. This removes some assumptions about the use of vendoring, and hard-coded knowledge of the apm-server directory structure. * Account for versioned import paths
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR updates the dev-tools/mage code to use "go list" to locate the root directory of the elastic/beats module.
Why is it important?
This removes some assumptions about the use of vendoring, and hard-coded knowledge of the apm-server directory structure. When we move to modules, the apm-server project will not be vendoring, and won't have a "_beats" top-level directory.
Checklist
- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration filesHow to test this PR locally
Run
mage buildin the filebeat directory.Related issues