[Filebeat] Improve ECS categorization field mappings in googlecloud module #16500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leehinman
added
enhancement
Filebeat
|
Pinging @elastic/siem (Team:SIEM) |
leehinman
force-pushed
the
16160_googlecloud_ecs_1.4
branch
from
b6aff0b
to
1aac440
Compare
andrewkroh
approved these changes
Feb 22, 2020
There was a problem hiding this comment.
I think this fully addresses #15651 too. So that can be closed by this.
| @@ -123,8 +125,9 @@ function Audit(keep_original_message) { | |||
| } | |||
| }; | |||
|
|
|||
| // Set event.outcome based on authentication_info and status. | |||
| var setEventOutcome = function(evt) { | |||
| // Set ECS categorization fields | |||
There was a problem hiding this comment.
This documentation no longer reads so well. Maybe it just needs a period?
| @@ -38,6 +38,7 @@ function Audit(keep_original_message) { | |||
| var saveMetadata = new processor.Convert({ | |||
| fields: [ | |||
| {from: "json.logName", to: "log.logger"}, | |||
| {from: "json.insertId", to: "event.id"}, | |||
There was a problem hiding this comment.
The pubsub input sets this field already but this is a better value.
+ audit - event.id - event.action - event.kind + firewall - event.kind - event.category - event.type - event.action - event.id - rule.name + vpcflow - event.kind - event.category - event.type - event.id Closes elastic#16030 Closes elastic#15651
leehinman
force-pushed
the
16160_googlecloud_ecs_1.4
branch
from
1aac440
to
01d7cd2
Compare
leehinman
added a commit
to leehinman/beats
that referenced
this pull request
Feb 24, 2020
…odule (elastic#16500) + audit - event.id - event.action - event.kind + firewall - event.kind - event.category - event.type - event.action - event.id - rule.name + vpcflow - event.kind - event.category - event.type - event.id Closes elastic#16030 Closes elastic#15651 (cherry picked from commit e1fa198)
leehinman
added
v7.7.0
and removed
needs_backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
audit
firewall
vpcflow
Closes #16030