-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allowing users to override pipeline ID in fileset input config #16561
Allowing users to override pipeline ID in fileset input config #16561
Conversation
jenkins, test this |
93e6769
to
0af4a00
Compare
0af4a00
to
e432180
Compare
input map[string]interface{} | ||
expectedFn require.ValueAssertionFunc | ||
}{ | ||
"close_eof": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe a changelog?
a707d5a
to
959c42c
Compare
959c42c
to
a01679f
Compare
CI failures are unrelated and also seen on master. Merging. |
@ycombinator : do we have this possibility explained and showed in any public doc? I haven't been able to find it. |
@eedugon We don't have a document specifically showing this option because it's just another input setting that can be overridden. We have this document that shows how to override input settings in general for any module: https://www.elastic.co/guide/en/beats/filebeat/master/advanced-settings.html#advanced-settings. And if you look at the settings under any input, |
What does this PR do?
This PR allows users to override the ingest pipeline for a fileset with their custom one. To do this, users must specify the
pipeline
configuration option (common to all Filebeat inputs) in their fileset configuration'sinput
section. For example:Why is it important?
Allows users to perform custom processing instead of the default processing provided by the ingest pipelines that come out-of-the-box with module filesets.
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration filesRelated issues
Use cases
See https://discuss.elastic.co/t/filebeat-cannot-change-pipeline-in-nginx-module/219360.