Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #16554 to 7.6: Fix k8s pod annotations tier in metadata #16581

Merged
merged 2 commits into from
Feb 26, 2020

Conversation

ChrsMark
Copy link
Member

Cherry-pick of PR #16554 to 7.6 branch. Original message:

Follow-up of #16480 PR.

It was found also that kubernetes.annotations.* do not follow the schema defined at

any more.

This PR aims to fix it.

Not sure if we should fix it in general for all resources at

safemapstr.Put(meta, strings.ToLower(kind)+".annotations", annotationsMap)
and not only for pods. I think we should do it sooner or later when we define a general strategy about this schema as mentioned #16480 (comment).

@ChrsMark
Copy link
Member Author

jenkins, test this please

@ChrsMark ChrsMark merged commit f9437a3 into elastic:7.6 Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants