Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #16421 to 7.x: Add container azure metricset #16755

Merged
merged 2 commits into from
Mar 3, 2020
Merged

Cherry-pick #16421 to 7.x: Add container azure metricset #16755

merged 2 commits into from
Mar 3, 2020

Conversation

narph
Copy link
Contributor

@narph narph commented Mar 3, 2020 •
edited by zube bot
Loading

Cherry-pick of PR #16421 to 7.x branch. Original message:

should solve #15751

Added container_service , container_instance and container_registry metricsets:

Config:

  - module: azure
    metricsets:
    - container_service
    enabled: true
    period: 300s
    client_id: '${AZURE_CLIENT_ID:""}'
    client_secret: '${AZURE_CLIENT_SECRET:""}'
    tenant_id: '${AZURE_TENANT_ID:""}'
    subscription_id: '${AZURE_SUBSCRIPTION_ID:""}'

  - module: azure
    metricsets:
    - container_instance
    enabled: true
    period: 300s
    client_id: '${AZURE_CLIENT_ID:""}'
    client_secret: '${AZURE_CLIENT_SECRET:""}'
    tenant_id: '${AZURE_TENANT_ID:""}'
    subscription_id: '${AZURE_SUBSCRIPTION_ID:""}'

  - module: azure
    metricsets:
    - container_registry
    enabled: true
    period: 300s
    client_id: '${AZURE_CLIENT_ID:""}'
    client_secret: '${AZURE_CLIENT_SECRET:""}'
    tenant_id: '${AZURE_TENANT_ID:""}'
    subscription_id: '${AZURE_SUBSCRIPTION_ID:""}'

extra config options as in the other metricsets:

resources:
 - resource_group: []
 - resource_id: []

@narph
Add container azure metricset (elastic#16421)
89525e9 
* add container

* update changelog

* fix test

* separate container

* separate

* regenerate

* fixes

* tests

* fix test

(cherry picked from commit d89675f)
@narph narph requested a review from a team as a code owner March 3, 2020 11:11
@narph narph self-assigned this Mar 3, 2020
@narph narph added [zube]: In Review Team:Integrations Label for the Integrations team Team:Platforms Label for the Integrations - Platforms team labels Mar 3, 2020
@narph narph changed the title Cherry-pick #16421 to 7.x: [Metricbeat] Redis Enterprise: add "node" and "proxy" metricsets Cherry-pick #16421 to 7.x: Add container azure metricset Mar 3, 2020
@narph narph merged commit 6edc696 into elastic:7.x Mar 3, 2020
@narph narph deleted the backport_16421_7.x branch March 3, 2020 18:42
@narph narph added test-plan Add this PR to be manual test plan v7.7.0 backport and removed test-plan Add this PR to be manual test plan v7.7.0 labels Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exekias exekias exekias approved these changes

Assignees

@narph narph

Labels
backport Team:Integrations Label for the Integrations team Team:Platforms Label for the Integrations - Platforms team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@narph @exekias @andresrc