Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix zeek pipelines to include millisecond precision #16766

Merged
merged 2 commits into from
Mar 3, 2020
Merged

Fix zeek pipelines to include millisecond precision #16766

merged 2 commits into from
Mar 3, 2020

Conversation

andrewstucki
Copy link
Contributor

What does this PR do?

Fixes #14599 by using a date processor in all zeek ingest pipeline.

Checklist

  • My code follows the style guidelines of this project
  • I have added tests that prove my fix is effective or that my feature works

@andrewstucki andrewstucki requested a review from a team as a code owner March 3, 2020 17:18
@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

leehinman
leehinman previously requested changes Mar 3, 2020
View reviewed changes
Copy link
Contributor

@leehinman leehinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code changes look good.

needs an entry in CHANGELOG.next.asciidoc

@andrewkroh andrewkroh added the needs_backport PR is waiting to be backported to other branches. label Mar 3, 2020
andrewkroh
andrewkroh approved these changes Mar 3, 2020
View reviewed changes
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Congrats your first Beats PR 🍾 .

@andrewstucki andrewstucki merged commit 2c310c0 into elastic:master Mar 3, 2020
@andrewstucki andrewstucki deleted the bugfix_zeek_timestamp branch March 3, 2020 18:23
andrewstucki pushed a commit to andrewstucki/beats that referenced this pull request Mar 3, 2020
Fix zeek pipelines to include millisecond precision (elastic#16766)
88414db 
* Fix zeek pipelines to include millisecond precision

* Add changelog entry

(cherry picked from commit 2c310c0)
@andrewstucki andrewstucki mentioned this pull request Mar 3, 2020
Merged
2 tasks
@andrewstucki andrewstucki added v7.6.1 and removed needs_backport PR is waiting to be backported to other branches. labels Mar 3, 2020
@andrewstucki andrewstucki mentioned this pull request Mar 3, 2020
Merged
2 tasks
andrewstucki pushed a commit to andrewstucki/beats that referenced this pull request Mar 3, 2020
Fix zeek pipelines to include millisecond precision (elastic#16766)
7f7344a 
* Fix zeek pipelines to include millisecond precision

* Add changelog entry

(cherry picked from commit 2c310c0)
andrewstucki pushed a commit that referenced this pull request Mar 3, 2020
Fix zeek pipelines to include millisecond precision (#16766) (#16769)
42353ad 
* Fix zeek pipelines to include millisecond precision

* Add changelog entry

(cherry picked from commit 2c310c0)
andrewstucki pushed a commit that referenced this pull request Mar 9, 2020
Cherry-pick #16766 to 7.6: Fix zeek pipelines to include millisecond …
ac71fe2 
…precision (#16768)

* Fix zeek pipelines to include millisecond precision (#16766)

* Fix zeek pipelines to include millisecond precision

* Add changelog entry

(cherry picked from commit 2c310c0)

* Fix Changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

@leehinman leehinman Awaiting requested review from leehinman

Assignees
No one assigned
Labels
bug Filebeat Filebeat review v7.6.1 v7.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Zeek ingest pipeline ignores millisecond in the timestamp
4 participants
@andrewstucki @elasticmachine @andrewkroh @leehinman