Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate haproxy module docs #16776

Merged
merged 1 commit into from
Mar 4, 2020
Merged

Generate haproxy module docs #16776

merged 1 commit into from
Mar 4, 2020

Conversation

ycombinator
Copy link
Contributor

Completes the change started in #16703.

@ycombinator ycombinator mentioned this pull request Mar 3, 2020
Merged
@ycombinator ycombinator requested a review from dedemorton March 3, 2020 21:10
@ycombinator ycombinator added docs needs_backport PR is waiting to be backported to other branches. review v8.0.0 labels Mar 3, 2020
mikemadden42
mikemadden42 approved these changes Mar 3, 2020
View reviewed changes
Copy link
Contributor

@mikemadden42 mikemadden42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dedemorton
Copy link
Contributor

Oh that's weird because my local branch has the changed docs file. But I guess the PR didn't show it was changed because I created my PR before Steffen reverted the original PR that broke the CI. Anyhow, this looks good. Thanks for catching it!

@ycombinator
Copy link
Contributor Author

CI failures are unrelated and also happening on master. Merging.

@ycombinator ycombinator merged commit f686982 into elastic:master Mar 4, 2020
@ycombinator ycombinator deleted the mb-haproxy-gen-docs branch March 4, 2020 00:13
This was referenced Mar 4, 2020
Closed
Closed
ycombinator added a commit that referenced this pull request Mar 5, 2020
@ycombinator @dedemorton
[7.6] [docs] Add username and password to haproxy example (#16703) (#…
d71063b 
…16801)

* [docs] Add username and password to haproxy example (#16703)

* Generate haproxy module docs (#16776)

Co-authored-by: DeDe Morton <dede.morton@elastic.co>
ycombinator added a commit that referenced this pull request Mar 6, 2020
@ycombinator @dedemorton
[7.x] [docs] Add username and password to haproxy example (#16703) (#…
c803833 
…16800)

* [docs] Add username and password to haproxy example (#16703)

* Generate haproxy module docs (#16776)

Co-authored-by: DeDe Morton <dede.morton@elastic.co>
@ycombinator ycombinator removed the needs_backport PR is waiting to be backported to other branches. label Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikemadden42 mikemadden42 mikemadden42 approved these changes

@dedemorton dedemorton dedemorton approved these changes

Assignees
No one assigned
Labels
docs review v7.6.2 v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ycombinator @dedemorton @mikemadden42