Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #17105 to 7.x: Copy missing go version to the generated Beats #17118

Merged
merged 1 commit into from
Mar 19, 2020
Merged

Cherry-pick #17105 to 7.x: Copy missing go version to the generated Beats #17118

merged 1 commit into from
Mar 19, 2020

Conversation

kvch
Copy link
Contributor

@kvch kvch commented Mar 19, 2020 •
edited by zube bot
Loading

Cherry-pick of PR #17105 to 7.x branch. Original message:

What does this PR do?

This PR makes beat generator copy .go-version to the vendored beats folder as it is not copied automatically.

Why is it important?

If the file .go-version is missing, the beat cannot be generated and package properly.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works

How to test this PR locally

$ make -C generator/_templates/beat test test-package

Related issues

@kvch
Copy missing go version to the generated Beats (elastic#17105)
3291641 
This PR makes beat generator copy `.go-version` to the vendored beats folder as it is not copied automatically.

If the file `.go-version` is missing, the beat cannot be generated and package properly.
(cherry picked from commit 6cf8764)
@kvch kvch added [zube]: In Review backport Team:Services (Deprecated) Label for the former Integrations-Services team labels Mar 19, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-services (Team:Services)

@kvch kvch merged commit 843d7da into elastic:7.x Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsoriano jsoriano jsoriano approved these changes

@fearful-symmetry fearful-symmetry Awaiting requested review from fearful-symmetry

Assignees
No one assigned
Labels
backport Team:Services (Deprecated) Label for the former Integrations-Services team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kvch @elasticmachine @jsoriano @andresrc