-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for MODULE in mage goIntegTest for metricbeat #17147
Merged
jsoriano
merged 4 commits into
elastic:master
from
jsoriano:module-env-var-mage-integ-test
Apr 1, 2020
Merged
Add support for MODULE in mage goIntegTest for metricbeat #17147
jsoriano
merged 4 commits into
elastic:master
from
jsoriano:module-env-var-mage-integ-test
Apr 1, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsoriano
added
review
:Testing
[zube]: In Review
Team:Integrations
Label for the Integrations team
labels
Mar 20, 2020
Pinging @elastic/integrations (Team:Integrations) |
sayden
approved these changes
Mar 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
kaiyan-sheng
approved these changes
Mar 20, 2020
5 tasks
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Apr 1, 2020
) Add support for `MODULE` environment variable in `mage goIntegTest` for Metricbeat to run integration tests for an specific module. For example, to run integration tests for sql module only: MODULE=sql mage goIntegTest (cherry picked from commit 13592b0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Metricbeat
Metricbeat
module
review
Team:Integrations
Label for the Integrations team
:Testing
v7.8.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add support for
MODULE
environment variable inmage goIntegTest
for Metricbeat to run integration tests for an specific module. For example, to run integration tests for sql module only:Why is it important?
Metricbeat integration tests are slow, running them as they are run in CI requires to run all tests, but when running them locally you are usually interested in running a single module.
Checklist
I have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature worksHow to test this PR locally
Use
MODULE
environment variable to run integration tests of a single module, for example: