Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for MODULE in mage goIntegTest for metricbeat #17147

Merged
merged 4 commits into from
Apr 1, 2020

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented Mar 20, 2020

What does this PR do?

Add support for MODULE environment variable in mage goIntegTest for Metricbeat to run integration tests for an specific module. For example, to run integration tests for sql module only:

MODULE=sql mage goIntegTest

Why is it important?

Metricbeat integration tests are slow, running them as they are run in CI requires to run all tests, but when running them locally you are usually interested in running a single module.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works

How to test this PR locally

Use MODULE environment variable to run integration tests of a single module, for example:

MODULE=sql mage goIntegTest

@jsoriano jsoriano self-assigned this Mar 20, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

Copy link
Contributor

@sayden sayden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsoriano jsoriano merged commit 13592b0 into elastic:master Apr 1, 2020
@jsoriano jsoriano deleted the module-env-var-mage-integ-test branch April 1, 2020 17:16
@jsoriano jsoriano added the v7.8.0 label Apr 1, 2020
jsoriano added a commit to jsoriano/beats that referenced this pull request Apr 1, 2020
)

Add support for `MODULE` environment variable in `mage goIntegTest`
for Metricbeat to run integration tests for an specific module. For example,
to run integration tests for sql module only:

  MODULE=sql mage goIntegTest

(cherry picked from commit 13592b0)
jsoriano added a commit that referenced this pull request Apr 6, 2020
…17409)

Add support for `MODULE` environment variable in `mage goIntegTest`
for Metricbeat to run integration tests for an specific module. For example,
to run integration tests for sql module only:

  MODULE=sql mage goIntegTest

(cherry picked from commit 13592b0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants