Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dashboards for the azure container metricsets #17194

Merged
merged 4 commits into from
Mar 24, 2020
Merged

Add dashboards for the azure container metricsets #17194

merged 4 commits into from
Mar 24, 2020

Conversation

narph
Copy link
Contributor

@narph narph commented Mar 24, 2020

Adding dashboards for the container_service, container_instance and container_registry azure metricsets:

image

image

image

@narph narph self-assigned this Mar 24, 2020
@narph narph added [zube]: In Review enhancement Metricbeat Metricbeat needs_backport PR is waiting to be backported to other branches. Team:Integrations Label for the Integrations team Team:Platforms Label for the Integrations - Platforms team and removed enhancement labels Mar 24, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@zube zube bot added enhancement and removed Team:Integrations Label for the Integrations team Team:Platforms Label for the Integrations - Platforms team labels Mar 24, 2020
@narph narph requested a review from sorantis March 24, 2020 08:33
@sayden
Copy link
Contributor

sayden commented Mar 24, 2020

Remember to remove the [Metricbeat Azure] prefix from the title on the dashboard visualizations.

nit: I think you can also rename the "Total * Count" to simply "Total *"

@kaiyan-sheng
Copy link
Contributor

kaiyan-sheng commented Mar 24, 2020 •
edited
Loading

For the dashboard, if you zoom in to show only data points between 18:00 to 21:00, then it's not gonna be as empty. WDYT? This is just a suggestion for making the screenshot look better(with more data points).

@narph
Copy link
Contributor Author

narph commented Mar 24, 2020

image

image

image

@sayden sayden self-requested a review March 24, 2020 14:11
sayden
sayden approved these changes Mar 24, 2020
View reviewed changes
Copy link
Contributor

@sayden sayden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kaiyan-sheng
kaiyan-sheng reviewed Mar 24, 2020
View reviewed changes
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@narph Are you planning to add screenshot of these new dashboards into https://github.com/elastic/beats/tree/master/metricbeat/docs/images?

@narph
Copy link
Contributor Author

narph commented Mar 24, 2020

@narph Are you planning to add screenshot of these new dashboards into https://github.com/elastic/beats/tree/master/metricbeat/docs/images?

@kaiyan-sheng, will do

@narph narph merged commit 50d8656 into elastic:master Mar 24, 2020
@narph narph deleted the container-dashboard branch March 24, 2020 16:01
narph added a commit to narph/beats that referenced this pull request Mar 24, 2020
@narph
Add dashboards for the azure container metricsets (elastic#17194)
077a2e7 
* Add dashboards

* changelog

* update title

(cherry picked from commit 50d8656)
@narph narph mentioned this pull request Mar 24, 2020
Merged
narph added a commit that referenced this pull request Mar 24, 2020
@narph
Add dashboards for the azure container metricsets (#17194) (#17210)
51fbc24 
* Add dashboards

* changelog

* update title

(cherry picked from commit 50d8656)
@narph narph added test-plan Add this PR to be manual test plan v7.7.0 and removed needs_backport PR is waiting to be backported to other branches. labels Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaiyan-sheng kaiyan-sheng kaiyan-sheng left review comments

@sayden sayden sayden approved these changes

@sorantis sorantis Awaiting requested review from sorantis

Assignees

@narph narph

Labels
enhancement Metricbeat Metricbeat test-plan Add this PR to be manual test plan v7.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@narph @elasticmachine @sayden @kaiyan-sheng @andresrc