-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CEF processor mapping exception #17220
Merged
adriansr
merged 2 commits into
elastic:master
from
adriansr:fix_17216_cef_group_mapping
Mar 24, 2020
Merged
Fix CEF processor mapping exception #17220
adriansr
merged 2 commits into
elastic:master
from
adriansr:fix_17216_cef_group_mapping
Mar 24, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extensions spriv/dpriv were mapped to {source|destination}.user.group instead of {source|destination}.user.group.name. This caused a mapping exception when attempting to ingest CEF logs that used those extensions. Fixes elastic#17216
adriansr
added
bug
Filebeat
Filebeat
needs_backport
PR is waiting to be backported to other branches.
Team:SIEM
labels
Mar 24, 2020
Pinging @elastic/siem (Team:SIEM) |
leehinman
approved these changes
Mar 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code change looks good. Should probably have a Changelog entry though.
leehinman
approved these changes
Mar 24, 2020
andrewkroh
approved these changes
Mar 24, 2020
1 task
adriansr
added
v7.7.0
and removed
needs_backport
PR is waiting to be backported to other branches.
labels
Mar 24, 2020
adriansr
added a commit
to adriansr/beats
that referenced
this pull request
Mar 24, 2020
Extensions spriv/dpriv were mapped to {source|destination}.user.group instead of {source|destination}.user.group.name. This caused a mapping exception when attempting to ingest CEF logs that used those extensions. Fixes elastic#17216 (cherry picked from commit 99f483e)
1 task
adriansr
added a commit
to adriansr/beats
that referenced
this pull request
Mar 24, 2020
Extensions spriv/dpriv were mapped to {source|destination}.user.group instead of {source|destination}.user.group.name. This caused a mapping exception when attempting to ingest CEF logs that used those extensions. Fixes elastic#17216 (cherry picked from commit 99f483e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extensions
spriv
/dpriv
were mapped to{source|destination}.user.group
instead of{source|destination}.user.group.name
.This caused a mapping exception when attempting to ingest CEF logs that used those extensions.
Fixes #17216
What does this PR do?
Fixes the CEF decoder mapping of
spriv
/dpriv
extensions to {source|destination}.user.groupinstead of
{source|destination}.user.group.name`.Why is it important?
This caused a mapping exception when attempting to ingest CEF logs that used those extensions.
Checklist
[ ] My code follows the style guidelines of this project[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration filesRelated issues
Fixes #17216