[BUG] Use Pod.Status.Phase for pod updates in kubernetes autodiscovery #17223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
1 similar comment
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
💚 CLA has been signed |
This change fixes several issues with filebeat loosing events when using kubernetes autodiscovery by incorrectly handling of pod states. Switch the pod status verification in OnUpdate() from ObjectMeta.DeletionTimestamp (which is present only for deleted pods) to Pod.Status.Phase in order to correctly handle pod states. ObjectMeta.DeletionTimestamp is only present for deleted pods and when a pod runs to completion (eg. pods generated by conjobs), OnUpdate() will emit a pod stop event disrespecting the CleanupTimeout leading to early termination of running beats.
brunotm
force-pushed
the
brunotm.fix-k8s-pod-events
branch
from
d53603b
to
0c43a8e
Compare
exekias
added
containers
|
Pinging @elastic/integrations-platforms (Team:Platforms) |
|
This looks good to me, any other opinion @vjsamuel @ChrsMark @blakerouse? |
|
jenkins test this please |
|
I don't think they are related to this change, so let's ignore them for now |
blakerouse
approved these changes
Mar 25, 2020
blakerouse
requested changes
Mar 25, 2020
exekias
added
the
needs_backport
blakerouse
approved these changes
Mar 25, 2020
2 tasks
blakerouse
added
v7.8.0
and removed
needs_backport
blakerouse
pushed a commit
to blakerouse/beats
that referenced
this pull request
Mar 25, 2020
elastic#17223) * Use Pod.Status.Phase for pod updates in kubernetes autodiscovery This change fixes several issues with filebeat loosing events when using kubernetes autodiscovery by incorrectly handling of pod states. Switch the pod status verification in OnUpdate() from ObjectMeta.DeletionTimestamp (which is present only for deleted pods) to Pod.Status.Phase in order to correctly handle pod states. ObjectMeta.DeletionTimestamp is only present for deleted pods and when a pod runs to completion (eg. pods generated by conjobs), OnUpdate() will emit a pod stop event disrespecting the CleanupTimeout leading to early termination of running beats. * add issue PR reference to changelog (cherry picked from commit 70237a7)
blakerouse
pushed a commit
to blakerouse/beats
that referenced
this pull request
Mar 25, 2020
elastic#17223) * Use Pod.Status.Phase for pod updates in kubernetes autodiscovery This change fixes several issues with filebeat loosing events when using kubernetes autodiscovery by incorrectly handling of pod states. Switch the pod status verification in OnUpdate() from ObjectMeta.DeletionTimestamp (which is present only for deleted pods) to Pod.Status.Phase in order to correctly handle pod states. ObjectMeta.DeletionTimestamp is only present for deleted pods and when a pod runs to completion (eg. pods generated by conjobs), OnUpdate() will emit a pod stop event disrespecting the CleanupTimeout leading to early termination of running beats. * add issue PR reference to changelog (cherry picked from commit 70237a7)
2 tasks
|
Thanks for the quick feedback on this one. |
|
Thank you for contributing!! |
blakerouse
added a commit
that referenced
this pull request
Mar 26, 2020
#17223) (#17247) * Use Pod.Status.Phase for pod updates in kubernetes autodiscovery This change fixes several issues with filebeat loosing events when using kubernetes autodiscovery by incorrectly handling of pod states. Switch the pod status verification in OnUpdate() from ObjectMeta.DeletionTimestamp (which is present only for deleted pods) to Pod.Status.Phase in order to correctly handle pod states. ObjectMeta.DeletionTimestamp is only present for deleted pods and when a pod runs to completion (eg. pods generated by conjobs), OnUpdate() will emit a pod stop event disrespecting the CleanupTimeout leading to early termination of running beats. * add issue PR reference to changelog (cherry picked from commit 70237a7) Co-authored-by: Bruno Moura <brunotm@gmail.com>
blakerouse
added a commit
that referenced
this pull request
Mar 26, 2020
#17223) (#17248) * Use Pod.Status.Phase for pod updates in kubernetes autodiscovery This change fixes several issues with filebeat loosing events when using kubernetes autodiscovery by incorrectly handling of pod states. Switch the pod status verification in OnUpdate() from ObjectMeta.DeletionTimestamp (which is present only for deleted pods) to Pod.Status.Phase in order to correctly handle pod states. ObjectMeta.DeletionTimestamp is only present for deleted pods and when a pod runs to completion (eg. pods generated by conjobs), OnUpdate() will emit a pod stop event disrespecting the CleanupTimeout leading to early termination of running beats. * add issue PR reference to changelog (cherry picked from commit 70237a7) Co-authored-by: Bruno Moura <brunotm@gmail.com>
3 tasks
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
elastic#17223) (elastic#17248) * Use Pod.Status.Phase for pod updates in kubernetes autodiscovery This change fixes several issues with filebeat loosing events when using kubernetes autodiscovery by incorrectly handling of pod states. Switch the pod status verification in OnUpdate() from ObjectMeta.DeletionTimestamp (which is present only for deleted pods) to Pod.Status.Phase in order to correctly handle pod states. ObjectMeta.DeletionTimestamp is only present for deleted pods and when a pod runs to completion (eg. pods generated by conjobs), OnUpdate() will emit a pod stop event disrespecting the CleanupTimeout leading to early termination of running beats. * add issue PR reference to changelog (cherry picked from commit b919f23) Co-authored-by: Bruno Moura <brunotm@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This change fixes several issues with beats loosing events when
using kubernetes autodiscovery by incorrectly handling of pod states.
Switch the pod status verification in OnUpdate() from
ObjectMeta.DeletionTimestamp (which is present only for deleted pods)
to Pod.Status.Phase in order to correctly handle pod states.
ObjectMeta.DeletionTimestamp is only present for deleted pods and when a
pod runs to completion (eg. pods generated by conjobs), OnUpdate()
will emit a pod stop event disrespecting the CleanupTimeout and leading to
early termination of running beats.
Why is it important?
Avoids missing log, audit and metrics data when using kubernetes autodiscovery.
Checklist
- [] I have made corresponding changes to the documentation- [] I have made corresponding change to the default configuration files- [] I have added tests that prove my fix is effective or that my feature worksFixes #17246