Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow a wider range of characters for logstash.log.pipeline_id #17243

Merged
merged 6 commits into from
Mar 30, 2020

Conversation

lucabelluccini
Copy link
Contributor

@lucabelluccini lucabelluccini commented Mar 25, 2020

What does this PR do?

Allow a wider range of characters for logstash.log.pipeline_id.
The NOTSPACE should be fine, but for covering any case, DATA would be safer.

Why is it important?

Should solve #17242

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • Ensure it passes a test as I do not have the dev environment running at the moment

How to test this PR locally

Related issues

Allow a wider range of characters for `logstash.log.pipeline_id`.
The `NOTSPACE` should be fine, but for covering any case, `DATA` would be safer.
Should solve #17242
@ycombinator ycombinator added Team:Services (Deprecated) Label for the former Integrations-Services team v7.6.3 v7.7.0 v8.0.0 labels Mar 25, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-services (Team:Services)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/stack-monitoring (Stack monitoring)

@lucabelluccini
Copy link
Contributor Author

I've patched the test with the correct values, let's wait for the CI.

@ycombinator ycombinator marked this pull request as ready for review March 30, 2020 13:05
@ycombinator
Copy link
Contributor

Hey @lucabelluccini, CI is looking good on these changes. Travis CI is green and Jenkins CI failures are unrelated.

Could you add an entry in CHANGELOG.next.asciidoc for this change please?

@lucabelluccini
Copy link
Contributor Author

CHANGELOG.next.asciidoc updated

@adriansr
Copy link
Contributor

Thanks for fixing this @lucabelluccini

Copy link
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the PR @lucabelluccini! <3

@ycombinator ycombinator merged commit a59768f into master Mar 30, 2020
@ycombinator ycombinator deleted the beats-17242 branch March 30, 2020 18:00
@ycombinator ycombinator removed the needs_backport PR is waiting to be backported to other branches. label Mar 30, 2020
ycombinator added a commit that referenced this pull request Mar 30, 2020
…17243) (#17338)

* Allow a wider range of characters for logstash.log.pipeline_id (#17243)

* Allow a wider range of characters for logstash.log.pipeline_id

Allow a wider range of characters for `logstash.log.pipeline_id`.
The `NOTSPACE` should be fine, but for covering any case, `DATA` would be safer.
Should solve #17242

* update tests for logstash plain 7.4 pipeline id

* Failed tests

* update changelog

* CHANGELOG grooming

Co-authored-by: Luca Belluccini <luca.belluccini@elastic.co>
ycombinator added a commit that referenced this pull request Mar 31, 2020
…17243) (#17357)

* Allow a wider range of characters for logstash.log.pipeline_id (#17243)

* Allow a wider range of characters for logstash.log.pipeline_id

Allow a wider range of characters for `logstash.log.pipeline_id`.
The `NOTSPACE` should be fine, but for covering any case, `DATA` would be safer.
Should solve #17242

* update tests for logstash plain 7.4 pipeline id

* Failed tests

* update changelog

* CHANGELOG grooming

Co-authored-by: Luca Belluccini <luca.belluccini@elastic.co>
ycombinator added a commit that referenced this pull request Apr 2, 2020
…17243) (#17339)

* Allow a wider range of characters for logstash.log.pipeline_id (#17243)

* Allow a wider range of characters for logstash.log.pipeline_id

Allow a wider range of characters for `logstash.log.pipeline_id`.
The `NOTSPACE` should be fine, but for covering any case, `DATA` would be safer.
Should solve #17242

* update tests for logstash plain 7.4 pipeline id

* Failed tests

* update changelog

* CHANGELOG grooming

* Removing fields that are not available in Filebeat 7.6

Co-authored-by: Luca Belluccini <luca.belluccini@elastic.co>
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
…lastic#17243) (elastic#17357)

* Allow a wider range of characters for logstash.log.pipeline_id (elastic#17243)

* Allow a wider range of characters for logstash.log.pipeline_id

Allow a wider range of characters for `logstash.log.pipeline_id`.
The `NOTSPACE` should be fine, but for covering any case, `DATA` would be safer.
Should solve elastic#17242

* update tests for logstash plain 7.4 pipeline id

* Failed tests

* update changelog

* CHANGELOG grooming

Co-authored-by: Luca Belluccini <luca.belluccini@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Feature:Stack Monitoring Team:Services (Deprecated) Label for the former Integrations-Services team v7.6.3 v7.7.0 v7.8.0 v8.0.0
Projects
None yet
5 participants