-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow a wider range of characters for logstash.log.pipeline_id #17243
Conversation
Allow a wider range of characters for `logstash.log.pipeline_id`. The `NOTSPACE` should be fine, but for covering any case, `DATA` would be safer. Should solve #17242
Pinging @elastic/integrations-services (Team:Services) |
Pinging @elastic/stack-monitoring (Stack monitoring) |
I've patched the test with the correct values, let's wait for the CI. |
Hey @lucabelluccini, CI is looking good on these changes. Travis CI is green and Jenkins CI failures are unrelated. Could you add an entry in |
|
Thanks for fixing this @lucabelluccini |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the PR @lucabelluccini! <3
…17243) (#17338) * Allow a wider range of characters for logstash.log.pipeline_id (#17243) * Allow a wider range of characters for logstash.log.pipeline_id Allow a wider range of characters for `logstash.log.pipeline_id`. The `NOTSPACE` should be fine, but for covering any case, `DATA` would be safer. Should solve #17242 * update tests for logstash plain 7.4 pipeline id * Failed tests * update changelog * CHANGELOG grooming Co-authored-by: Luca Belluccini <luca.belluccini@elastic.co>
…17243) (#17357) * Allow a wider range of characters for logstash.log.pipeline_id (#17243) * Allow a wider range of characters for logstash.log.pipeline_id Allow a wider range of characters for `logstash.log.pipeline_id`. The `NOTSPACE` should be fine, but for covering any case, `DATA` would be safer. Should solve #17242 * update tests for logstash plain 7.4 pipeline id * Failed tests * update changelog * CHANGELOG grooming Co-authored-by: Luca Belluccini <luca.belluccini@elastic.co>
…17243) (#17339) * Allow a wider range of characters for logstash.log.pipeline_id (#17243) * Allow a wider range of characters for logstash.log.pipeline_id Allow a wider range of characters for `logstash.log.pipeline_id`. The `NOTSPACE` should be fine, but for covering any case, `DATA` would be safer. Should solve #17242 * update tests for logstash plain 7.4 pipeline id * Failed tests * update changelog * CHANGELOG grooming * Removing fields that are not available in Filebeat 7.6 Co-authored-by: Luca Belluccini <luca.belluccini@elastic.co>
…lastic#17243) (elastic#17357) * Allow a wider range of characters for logstash.log.pipeline_id (elastic#17243) * Allow a wider range of characters for logstash.log.pipeline_id Allow a wider range of characters for `logstash.log.pipeline_id`. The `NOTSPACE` should be fine, but for covering any case, `DATA` would be safer. Should solve elastic#17242 * update tests for logstash plain 7.4 pipeline id * Failed tests * update changelog * CHANGELOG grooming Co-authored-by: Luca Belluccini <luca.belluccini@elastic.co>
What does this PR do?
Allow a wider range of characters for
logstash.log.pipeline_id
.The
NOTSPACE
should be fine, but for covering any case,DATA
would be safer.Why is it important?
Should solve #17242
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Author's Checklist
How to test this PR locally
Related issues