Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.x] Improve performance of metrics hashing in statsd module (#17309) #17333

Merged
merged 1 commit into from
Mar 30, 2020
Merged

[7.x] Improve performance of metrics hashing in statsd module (#17309) #17333

merged 1 commit into from
Mar 30, 2020

Conversation

roncohen
Copy link
Contributor

Backports the following commits to 7.x:

Improve performance of metrics hashing in statsd module (elastic#17309)
5dfb358 
This changes statsd metric tag hashing from being plain json
to using the xxhash for improved performance. In doing so it
moves a bit of hashing code used for prometheus labels around.

name      old time/op    new time/op    delta
Ingest-4    3.45µs ± 1%    2.81µs ±13%  -18.57%  (p=0.008 n=5+5)

name      old alloc/op   new alloc/op   delta
Ingest-4    1.50kB ± 0%    1.31kB ± 0%  -12.84%  (p=0.008 n=5+5)

name      old allocs/op  new allocs/op  delta
Ingest-4      29.0 ± 0%      23.0 ± 0%  -20.69%  (p=0.000 n=6+5)
@roncohen roncohen added the Team:Integrations Label for the Integrations team label Mar 30, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@roncohen roncohen self-assigned this Mar 30, 2020
@roncohen roncohen added backport enhancement Team:Platforms Label for the Integrations - Platforms team Team:Services (Deprecated) Label for the former Integrations-Services team and removed Team:Integrations Label for the Integrations team labels Mar 30, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-services (Team:Services)

blakerouse
blakerouse approved these changes Mar 30, 2020
View reviewed changes
Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@roncohen roncohen merged commit ce56566 into elastic:7.x Mar 30, 2020
@roncohen
Copy link
Contributor Author

thanks @blakerouse !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakerouse blakerouse blakerouse approved these changes

Assignees

@roncohen roncohen

Labels
backport enhancement Team:Platforms Label for the Integrations - Platforms team Team:Services (Deprecated) Label for the former Integrations-Services team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roncohen @elasticmachine @blakerouse