Always extract monitoring.cluster_uuid setting from Beat config #17420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ycombinator
added
the
Team:Services
|
Pinging @elastic/integrations-services (Team:Services) |
ycombinator
added
the
needs_backport
kvch
approved these changes
Apr 3, 2020
This was referenced Apr 3, 2020
ycombinator
added a commit
that referenced
this pull request
Apr 3, 2020
ycombinator
added a commit
that referenced
this pull request
Apr 3, 2020
…) (#17475) * Pass monitoring.* config object * Adding CHANGELOG entry * Adding system test
ycombinator
added a commit
that referenced
this pull request
Apr 3, 2020
…) (#17474) * Pass monitoring.* config object * Adding CHANGELOG entry * Adding system test
ycombinator
removed
the
needs_backport
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…tic#17420) (elastic#17475) * Pass monitoring.* config object * Adding CHANGELOG entry * Adding system test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR always parses out the value of the
monitoring.cluster_uuidsetting, regardless of whethermonitoring.enabledis set or not.Prior to this PR, if a user explicitly set
monitoring.enabledtofalseand also setmonitoring.cluster_uuidto some value, the latter setting's value would not be parsed out. However, if the user just omitted themonitoring.enabledsetting while settingmonitoring.cluster_uuidto some value, the latter setting's value would be parsed out. This behavior is buggy as the default value of themonitorig.enabledsetting isfalseso explicitly setting it as such or omitting that setting altogether should result in the same behaviors.Why is it important?
This setting's value (if this setting is set) must always be exposed in the
GET /stateBeats API, as this is used by the Metricbeatbeatmodule to monitor Beats.Checklist
I have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentationI have made corresponding change to the default configuration filesCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues