Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #17334 to 7.x: Add test for documented fields check for metricsets without a http input #17439

Merged
merged 2 commits into from
Apr 6, 2020
Merged

Cherry-pick #17334 to 7.x: Add test for documented fields check for metricsets without a http input #17439

merged 2 commits into from
Apr 6, 2020

Conversation

narph
Copy link
Contributor

@narph narph commented Apr 2, 2020

Cherry-pick of PR #17334 to 7.x branch. Original message:

What does this PR do?

Adds a test to check that the metricset fields are documented based on the events generated in the integration tests.

Why is it important?

This is a step in the requirements for moving modules/metricsets to GA.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

Add mbtest.TestMetricsetFieldsDocumented to the integration test

Related issues

@narph
Add test for documented fields check for metricsets without a http in…
a66ebc8 
…put (elastic#17334)

* add test for documented fields

* changelog

* work on test

* add test for testdata

* fmt update

(cherry picked from commit e545836)
@narph
update changelog
03f80a6
@narph narph self-assigned this Apr 3, 2020
@narph narph added [zube]: In Review backport Team:Integrations Label for the Integrations team labels Apr 3, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

blakerouse
blakerouse approved these changes Apr 3, 2020
View reviewed changes
Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@narph
Copy link
Contributor Author

narph commented Apr 6, 2020 •
edited
Loading

jenkins, test this please

@narph narph merged commit 33daf30 into elastic:7.x Apr 6, 2020
@narph narph deleted the backport_17334_7.x branch April 6, 2020 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakerouse blakerouse blakerouse approved these changes

Assignees

@narph narph

Labels
backport Team:Integrations Label for the Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@narph @elasticmachine @blakerouse @andresrc