-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New processor: urldecode #17505
New processor: urldecode #17505
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
1 similar comment
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
Pinging @elastic/integrations-services (Team:Services) |
Note to self (for review): Look at behavior of ES ingest node urldecode processor: https://www.elastic.co/guide/en/elasticsearch/reference/current/urldecode-processor.html. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this contribution, @sincejune! This PR is looking quite good; I just left a few nitpicks/minor comments.
I just noticed that this processor is placed under the |
Thanks @ycombinator , I moved (And I re-requested the review from you, accidentally removed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple more minor suggestions after the move to the new package. After that, I'll approve this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I'll merge it once CI looks good.
Thanks for the contribution, @sincejune!
CI failures are unrelated. Merging. |
Thanks for helping this, @ycombinator ! |
* New processor: urldecode (#17505) * add urldecode processor * update reference yml files * update doc with PR number * remove unexpected format * update from feedback * move urldecode processor into its own package * update from feedback * CHANGELOG grooming Co-authored-by: Chao <19381524+sincejune@users.noreply.github.com>
What does this PR do?
This PR introduces a new processor
urldecode
. To decode fields from URL encoded format use this processor withurldecode
.Why is it important?
This PR makes Filebeat can decode URL-encoded strings itself and then write to different outputs.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.