Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #17569 to 7.x: [Auditbeat][System] Fix error handling around go-sysinfo.Host #17602

Merged
merged 1 commit into from
Apr 9, 2020
Merged

Cherry-pick #17569 to 7.x: [Auditbeat][System] Fix error handling around go-sysinfo.Host #17602

merged 1 commit into from
Apr 9, 2020

Conversation

adriansr
Copy link
Contributor

@adriansr adriansr commented Apr 8, 2020 •
edited by andresrc
Loading

Cherry-pick of PR #17569 to 7.x branch. Original message:

Before a system dataset is loaded, host information is loaded to populate entity_id fields.

Error handling around it was incorrect and resulted in a panic when fetching host info failed, which afaik it's limited to errors accessing /proc/stat file.

@adriansr
[Auditbeat][System] Fix error handling around go-sysinfo.Host (elasti…
bf7990f 
…c#17569)

Before a system dataset is loaded, host information is loaded to
populate `entity_id` fields.

Error handling around it was incorrect and resulted in a panic when
fetching host info failed, which afaik it's limited to errors accessing
/proc/stat file.

(cherry picked from commit 97750c8)
@adriansr adriansr requested a review from a team as a code owner April 8, 2020 08:57
ycombinator
ycombinator approved these changes Apr 8, 2020
View reviewed changes
Copy link
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport LGTM.

@adriansr adriansr merged commit e2c9b6a into elastic:7.x Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ycombinator ycombinator ycombinator approved these changes

Assignees
No one assigned
Labels
backport review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adriansr @ycombinator