Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metricbeat] Fix "ID" event generator of Google Cloud module #17608

Merged

Conversation

sayden
Copy link
Contributor

@sayden sayden commented Apr 8, 2020

Fixes that ID that is generated for each TimeSeries event returned by Google Cloud. Fixes #17160

image

@sayden sayden added bug Metricbeat Metricbeat Team:Platforms Label for the Integrations - Platforms team labels Apr 8, 2020
@sayden sayden requested a review from kaiyan-sheng April 8, 2020 11:38
@sayden sayden self-assigned this Apr 8, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@jsoriano jsoriano added the v7.6.3 label Apr 8, 2020
@kaiyan-sheng
Copy link
Contributor

Tested with multiple subscriptions and topics and it work! Thanks!!

@sayden sayden merged commit 755c1ae into elastic:master Apr 8, 2020
sayden added a commit to sayden/beats that referenced this pull request Apr 8, 2020
…#17608)

Error is unrelated, merging

(cherry picked from commit 755c1ae)
sayden added a commit to sayden/beats that referenced this pull request Apr 8, 2020
…#17608)

Error is unrelated, merging

(cherry picked from commit 755c1ae)
sayden added a commit to sayden/beats that referenced this pull request Apr 8, 2020
…#17608)

Error is unrelated, merging

(cherry picked from commit 755c1ae)

# Conflicts:
#	x-pack/metricbeat/module/googlecloud/stackdriver/timeseries.go
sayden added a commit that referenced this pull request Apr 8, 2020
syepes pushed a commit to syepes/beats that referenced this pull request Apr 9, 2020
@sayden sayden deleted the bugfix/xp/mb/gcp/fix-id-for-generic-metricsets branch August 25, 2022 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Metricbeat Metricbeat Team:Platforms Label for the Integrations - Platforms team v7.6.3 v7.7.0 v7.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Metricbeat] pubsub metricset not collecting from all subscriptions and topics
4 participants