Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[metricbeat] add state_statefulset in metricbeat k8s recommended config #17627

Merged
merged 3 commits into from
Jul 15, 2020

Conversation

jmlrt
Copy link
Member

@jmlrt jmlrt commented Apr 9, 2020

What does this PR do?

This PR add state_statefulset metricset in recommended k8s configuration.

Why is it important?

state_* metricsets for other K8S recources like deployment, replicaset and pod are present in recommended configuration.

Any reason not to add statefulset?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@jmlrt jmlrt force-pushed the k8s_metricbeat_state_statefulset branch from 6c7efbd to e8891e3 Compare April 9, 2020 14:37
@andresrc andresrc added [zube]: Inbox Team:Platforms Label for the Integrations - Platforms team labels Apr 13, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@ChrsMark ChrsMark added the needs_backport PR is waiting to be backported to other branches. label Jul 15, 2020
@ChrsMark ChrsMark merged commit 5b380b6 into elastic:master Jul 15, 2020
ChrsMark pushed a commit to ChrsMark/beats that referenced this pull request Jul 15, 2020
…ig (elastic#17627)

* [metricbeat] add state_statefulset in metricbeat k8s recommended config

* [metricbeat] update changelog.next

Co-authored-by: Chris Mark <chrismarkou92@gmail.com>
(cherry picked from commit 5b380b6)
@ChrsMark ChrsMark added v7.9.0 and removed needs_backport PR is waiting to be backported to other branches. labels Jul 15, 2020
@jmlrt jmlrt deleted the k8s_metricbeat_state_statefulset branch July 15, 2020 10:30
ChrsMark added a commit that referenced this pull request Jul 15, 2020
…ig (#17627) (#19939)

* [metricbeat] add state_statefulset in metricbeat k8s recommended config

* [metricbeat] update changelog.next

Co-authored-by: Chris Mark <chrismarkou92@gmail.com>
(cherry picked from commit 5b380b6)

Co-authored-by: Julien Mailleret <8582351+jmlrt@users.noreply.github.com>
melchiormoulin pushed a commit to melchiormoulin/beats that referenced this pull request Oct 14, 2020
…ig (elastic#17627)

* [metricbeat] add state_statefulset in metricbeat k8s recommended config

* [metricbeat] update changelog.next

Co-authored-by: Chris Mark <chrismarkou92@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Team:Platforms Label for the Integrations - Platforms team v7.9.0 [zube]: Done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants