Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #17659 to 7.x: Add config option to select a different azure cloud env in the azure-eventhub input and azure module #17859

Merged
merged 2 commits into from
Apr 22, 2020

Conversation

narph
Copy link
Contributor

@narph narph commented Apr 21, 2020

Cherry-pick of PR #17659 to 7.x branch. Original message:

What does this PR do?

Adds override_resource_manager_endpoint config option to select a different azure cloud env in the azure-eventhub input and azure module.
Users should enter the resource manager endpoint in this case.
Ex:
https://management.chinacloudapi.cn/: azure.ChinaCloud,
https://management.microsoftazure.de/: azure.GermanCloud,
https://management.azure.com/: azure.PublicCloud,
https://management.usgovcloudapi.net/: azure.USGovernmentCloud,

Why is it important?

To support other azure cloud env besides the public one

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

…eventhub input and azure module (elastic#17659)

* add option to select a different azure env

* changelog

* rename

* add test

* mage fmt update

(cherry picked from commit 4e1d4b9)
@narph narph self-assigned this Apr 21, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@narph narph merged commit 0c9283a into elastic:7.x Apr 22, 2020
@narph narph deleted the backport_17659_7.x branch April 22, 2020 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Filebeat Filebeat Team:Integrations Label for the Integrations team v7.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants