-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Filebeat] Improve ECS categorization field mappings in osquery module #17881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leehinman
added
enhancement
Filebeat
Filebeat
needs_backport
PR is waiting to be backported to other branches.
Team:SIEM
ecs
labels
Apr 21, 2020
Pinging @elastic/siem (Team:SIEM) |
- event.action - event.kind - event.type - file.accessed - file.created - file.directory - file.gid - file.inode - file.mode - file.mtime - file.name - file.path - file.size - file.type - file.uid - host.hostname - host.id - process.name - related.user - rule.name - url.full - user.name Closes elastic#16176
leehinman
force-pushed
the
16176_osquery_ecs_1.4
branch
from
April 21, 2020 18:31
1fb8df5
to
ebae871
Compare
andrewkroh
reviewed
Apr 23, 2020
"set": { | ||
"field": "user.name", | ||
"value": "{{osquery.result.decorations.username}}", | ||
"if": "ctx?.osquery?.result?.decorations?.uusername != null" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
"if": "ctx?.osquery?.result?.decorations?.uusername != null" | |
"if": "ctx?.osquery?.result?.decorations?.username != null" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doh! Thanks for catching that.
andrewkroh
approved these changes
May 5, 2020
leehinman
force-pushed
the
16176_osquery_ecs_1.4
branch
from
May 5, 2020 14:31
dae0f7e
to
cdd3833
Compare
3 tasks
leehinman
added
v7.8.0
and removed
needs_backport
PR is waiting to be backported to other branches.
labels
May 5, 2020
leehinman
added a commit
to leehinman/beats
that referenced
this pull request
May 5, 2020
elastic#17881) * Improve ECS categorization field mappings in osquery module - event.action - event.kind - event.type - file.accessed - file.created - file.directory - file.gid - file.inode - file.mode - file.mtime - file.name - file.path - file.size - file.type - file.uid - host.hostname - host.id - process.name - related.user - rule.name - url.full - user.name Closes elastic#16176 * Fix misspelling of username & set ECS version (cherry picked from commit 282b084)
leehinman
added a commit
to leehinman/beats
that referenced
this pull request
May 5, 2020
PR 17881 didn't have updated golden files for osquery. This updates them. Related elastic#17881
1 task
leehinman
added a commit
that referenced
this pull request
May 5, 2020
PR 17881 didn't have updated golden files for osquery. This updates them. Related #17881
leehinman
added a commit
that referenced
this pull request
May 5, 2020
…d mappings in osquery module (#18245) * [Filebeat] Improve ECS categorization field mappings in osquery module (#17881) * Improve ECS categorization field mappings in osquery module - event.action - event.kind - event.type - file.accessed - file.created - file.directory - file.gid - file.inode - file.mode - file.mtime - file.name - file.path - file.size - file.type - file.uid - host.hostname - host.id - process.name - related.user - rule.name - url.full - user.name Closes #16176 * Fix misspelling of username & set ECS version (cherry picked from commit 282b084) * Update golden files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds the following field mappings to osquery module:
Why is it important?
Improve ECS field mappings makes data more useful in SIEM app and improves correlation between data sources.
Checklist
- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration filesCHANGELOG.next.asciidoc
orCHANGELOG.developer.next.asciidoc
.How to test this PR locally
Related issues
Closes #16176