Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Filebeat] Improve ECS categorization field mappings in redis module #17918

Merged
merged 2 commits into from
Apr 27, 2020

Conversation

leehinman
Copy link
Contributor

What does this PR do?

Adds ECS categorization fields to redis module. Specifically:

  • event.kind
  • event.category
  • event.type

Why is it important?

ECS categorization fields makes data more useful in SIEM app

Checklist

  • My code follows the style guidelines of this project
    - [ ] I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

TESTING_FILEBEAT_MODULES=redis mage -v pythonIntegTest

Related issues

Closes #16179

@leehinman leehinman added enhancement Filebeat Filebeat needs_backport PR is waiting to be backported to other branches. Team:SIEM ecs labels Apr 22, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

- event.kind
- event.category
- event.type

Closes elastic#16179
@leehinman
Copy link
Contributor Author

run tests

@leehinman leehinman merged commit cc6c4e3 into elastic:master Apr 27, 2020
@leehinman leehinman deleted the 16179_redis_ecs_1.4 branch April 27, 2020 13:55
@leehinman leehinman added v7.8.0 and removed needs_backport PR is waiting to be backported to other branches. labels Apr 27, 2020
leehinman added a commit to leehinman/beats that referenced this pull request Apr 27, 2020
)

- event.kind
- event.category
- event.type

Closes elastic#16179

(cherry picked from commit cc6c4e3)
leehinman added a commit that referenced this pull request Apr 29, 2020
…18010)

- event.kind
- event.category
- event.type

Closes #16179

(cherry picked from commit cc6c4e3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Filebeat] Upgrade redis module to ECS 1.4
3 participants