Document recent changes to nginx fileset as breaking changes #18026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR elastic#17844 introduced the following changes: - http.request.method is now lowercase - http.request.referrer is only set when nginx provides a value This PR updates the CHANGELOG to report this as a breaking change.
leehinman
added
bug
Filebeat
|
Pinging @elastic/siem (Team:SIEM) |
botelastic
bot
added
the
needs_team
exekias
approved these changes
Apr 28, 2020
|
run tests |
💚 Build Succeeded
Expand to view the summary
Build stats
|
Merged
1 task
leehinman
added
v7.8.0
and removed
needs_backport
leehinman
added a commit
to leehinman/beats
that referenced
this pull request
Apr 29, 2020
…#18026) PR elastic#17844 introduced the following changes: - http.request.method is now lowercase - http.request.referrer is only set when nginx provides a value This PR updates the CHANGELOG to report this as a breaking change. (cherry picked from commit 0de9b67)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
PR #17844 introduced the following changes:
This PR updates the CHANGELOG to report this as a breaking change.
Why is it important?
Notifies our users of a breaking change in behavior
Checklist
- [ ] My code follows the style guidelines of this project- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related Issues
Relates #17844