Cherry-pick #16306 to 7.x: Enable keystore for autodiscover static configuration #18089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit c1160e3)
botelastic
bot
added
the
needs_team
|
Pinging @elastic/integrations-platforms (Team:Platforms) |
exekias
reviewed
Apr 29, 2020
CHANGELOG.next.asciidoc
Outdated
| @@ -263,6 +263,8 @@ https://github.com/elastic/beats/compare/v7.0.0-alpha2...master[Check the HEAD d | |||
| - Add `replace` processor for replacing string values of fields. {pull}17342[17342] | |||
| - Add `urldecode` processor to for decoding URL-encoded fields. {pull}17505[17505] | |||
| - Add support for AWS IAM `role_arn` in credentials config. {pull}17658[17658] {issue}12464[12464] | |||
| - Add keystore support for autodiscover static configurations. {pull]16306[16306] | |||
| - Add Kerberos support to Elasticsearch output. {pull}17927[17927] | |||
kaiyan-sheng
approved these changes
Apr 29, 2020
💔 Build Failed
Expand to view the summary
Build stats
Test stats 🧪
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
|
It think I will include the "reverted" changes for the broken docs after #18097 is merged to master. |
|
Removed docs changes that were reverted on #18097 . |
exekias
approved these changes
Apr 30, 2020
|
jenkins, test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #16306 to 7.x branch. Original message:
Close #12597.
What this PR does
This PR makes use of keystore for containers/pods that are autodiscovered with static configurations only. Hint based configuration should not have access to the keystore for security reasons.
How to test it manually
autodiscoverwith static template:Check that REDIS metrics are successfully collected.
Try to start REDIS with a different password so as to make Metricbeat fail.
Now check that hints based autodiscovered containers have not access to the keystore:
You should see Metribeat failing to access REDIS since the password is not retrievable.
cc: @exekias