Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #18138 to 7.x: Add more kubernetes integration tests #18201

Merged
merged 1 commit into from
May 4, 2020

Conversation

blakerouse
Copy link
Contributor

Cherry-pick of PR #18138 to 7.x branch. Original message:

What does this PR do?

Adds more kubernetes intergration tests for kubelet, proxy, and scheduler metricsets.

Why is it important?

For better integration test coverage for kubernetes.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

MODULE=kubernetes mage goIntegTest

Related issues

* Performing testing on kubelet metrics.

* Add integration tests for kubelet, proxy, and scheduler.

* mage fmt

* Update to use GoVersion in pods create.

* Fix kubelet hosts string to connect with kind.

(cherry picked from commit 64f6e80)
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 4, 2020
@blakerouse blakerouse added Team:Platforms Label for the Integrations - Platforms team and removed needs_team Indicates that the issue/PR needs a Team:* label labels May 4, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@blakerouse blakerouse requested a review from a team May 4, 2020 19:02
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@blakerouse blakerouse merged commit 67b57c9 into elastic:7.x May 4, 2020
@blakerouse blakerouse deleted the backport_18138_7.x branch May 4, 2020 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport review Team:Platforms Label for the Integrations - Platforms team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants