Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Implement backoff for Kafka output (#17808) #18260

Merged
merged 3 commits into from
May 5, 2020

Conversation

ycombinator
Copy link
Contributor

Backports the following commits to 7.x:

@ycombinator ycombinator requested review from a team as code owners May 5, 2020 17:48
@ycombinator ycombinator added [zube]: In Review backport Team:Services (Deprecated) Label for the former Integrations-Services team labels May 5, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-services (Team:Services)

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 5, 2020
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

* Expose wait duration from backoff strategies

* Add backoff section to kafka output config

* Use equal jitter backoff strategy with kafka producer

* Adding CHANGELOG entry

* Adding backoff options to reference config template

* Update reference config files

* Implementing new Backoff interface

* Adding explanation of strategy choice to comment

* Implementing new Backoff interface

* Adding godoc

* Resetting backoff

* Updating test

* Adding godoc for interface

* Adding struct tags for config settings

* Implementing stateless backoff function

* Undoing changes to backoff strategies

* Adding godoc

* Fixing backoff duration calculation

* WIP: Add unit test

* Refactor seed functionality into common package

* Fix test

* Testing evolution of backoff value over retries

* Fixing refactoring of PRNG seeding after rebase

* Better failure message from test

* Moving test utilities to internal package

* Fixing calls

* Adding config options to template
@ycombinator
Copy link
Contributor Author

jenkins, test this please

@elasticmachine
Copy link
Collaborator

elasticmachine commented May 5, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview stats

Expand to view the summary

Build stats

Test stats 🧪

Test Results
Failed 0
Passed 5864
Skipped 891
Total 6755

@ycombinator ycombinator merged commit e0078f2 into elastic:7.x May 5, 2020
@ycombinator ycombinator deleted the backport/7.x/pr-17808 branch May 5, 2020 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport needs_team Indicates that the issue/PR needs a Team:* label Team:Services (Deprecated) Label for the former Integrations-Services team [zube]: Done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants