Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.x] Add ECS logging MVP to libbeat (#17974) #18262

Merged
merged 1 commit into from
May 5, 2020
Merged

[7.x] Add ECS logging MVP to libbeat (#17974) #18262

merged 1 commit into from
May 5, 2020

Conversation

simitt
Copy link
Contributor

@simitt simitt commented May 5, 2020

Backports the following commits to 7.x:

@simitt
Add ECS logging MVP to libbeat (elastic#17974)
4fde10e 
Enable minimal ECS conformant logging by setting `logging.ecs:true`:
* adds @timestamp, log.level, message and ecs.version to every log line
* if EnableCaller is set add log.origin.file and log.origin.line.
* logs error.message when error is given

implements elastic#17942
@simitt simitt requested review from a team as code owners May 5, 2020 18:00
@simitt simitt added the backport label May 5, 2020
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 5, 2020
ycombinator
ycombinator approved these changes May 5, 2020
View reviewed changes
Copy link
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport LGTM.

@elasticmachine
Copy link
Collaborator

💔 Build Failed

Pipeline View Test View Changes Artifacts preview stats

Expand to view the summary

Build stats

Test stats 🧪

Test Results
Failed 0
Passed 5824
Skipped 891
Total 6715

Log output

Expand to view the last 100 lines of log output 

[2020-05-05T20:06:03.161Z] + [ -f journalbeat/build/coverage/full.cov ]
[2020-05-05T20:06:05.583Z] Failed in branch Auditbeat x-pack
[2020-05-05T20:06:28.652Z] Body did not finish within grace period; terminating with extreme prejudice
[2020-05-05T20:06:31.962Z] Error when executing cleanup post condition:
[2020-05-05T20:06:31.962Z] org.jenkinsci.plugins.workflow.steps.FlowInterruptedException
[2020-05-05T20:06:31.962Z] 	at org.jenkinsci.plugins.workflow.steps.TimeoutStepExecution.cancel(TimeoutStepExecution.java:160)
[2020-05-05T20:06:31.962Z] 	at org.jenkinsci.plugins.workflow.steps.TimeoutStepExecution.access$100(TimeoutStepExecution.java:38)
[2020-05-05T20:06:31.962Z] 	at org.jenkinsci.plugins.workflow.steps.TimeoutStepExecution$1.run(TimeoutStepExecution.java:134)
[2020-05-05T20:06:31.962Z] 	at jenkins.security.ImpersonatingScheduledExecutorService$1.run(ImpersonatingScheduledExecutorService.java:58)
[2020-05-05T20:06:31.962Z] 	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
[2020-05-05T20:06:31.962Z] 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
[2020-05-05T20:06:31.962Z] 	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180)
[2020-05-05T20:06:31.962Z] 	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)
[2020-05-05T20:06:31.962Z] 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
[2020-05-05T20:06:31.962Z] 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
[2020-05-05T20:06:31.962Z] 	at java.lang.Thread.run(Thread.java:748)
[2020-05-05T20:06:31.962Z] 
[2020-05-05T20:06:32.009Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18262/src/github.com/elastic/beats
[2020-05-05T20:06:32.562Z] + find . -type f -name TEST*.xml -path */build/* -delete
[2020-05-05T20:06:32.773Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18262/src/github.com/elastic/beats/Lint
[2020-05-05T20:06:33.123Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18262/src/github.com/elastic/beats/Elastic-Agent-x-pack
[2020-05-05T20:06:33.480Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18262/src/github.com/elastic/beats/Elastic-Agent-x-pack-Windows
[2020-05-05T20:06:33.788Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18262/src/github.com/elastic/beats/Winlogbeat-oss
[2020-05-05T20:06:34.133Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18262/src/github.com/elastic/beats/Dockerlogbeat
[2020-05-05T20:06:34.454Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18262/src/github.com/elastic/beats/Metricbeat-OSS-Unit-tests
[2020-05-05T20:06:34.895Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18262/src/github.com/elastic/beats/Journalbeat-oss
[2020-05-05T20:06:35.192Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18262/src/github.com/elastic/beats/Generators-Metricbeat-Linux
[2020-05-05T20:06:35.596Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18262/src/github.com/elastic/beats/Heartbeat-oss
[2020-05-05T20:06:35.907Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18262/src/github.com/elastic/beats/Libbeat-x-pack
[2020-05-05T20:06:36.289Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18262/src/github.com/elastic/beats/Functionbeat-x-pack
[2020-05-05T20:06:36.678Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18262/src/github.com/elastic/beats/Filebeat-Windows
[2020-05-05T20:06:36.988Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18262/src/github.com/elastic/beats/Auditbeat-Linux
[2020-05-05T20:06:37.394Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18262/src/github.com/elastic/beats/Winlogbeat-Windows-x-pack
[2020-05-05T20:06:37.726Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18262/src/github.com/elastic/beats/Metricbeat-crosscompile
[2020-05-05T20:06:38.080Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18262/src/github.com/elastic/beats/Packetbeat-oss
[2020-05-05T20:06:38.414Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18262/src/github.com/elastic/beats/Filebeat-x-pack
[2020-05-05T20:06:38.864Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18262/src/github.com/elastic/beats/Metricbeat-Windows
[2020-05-05T20:06:39.242Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18262/src/github.com/elastic/beats/Filebeat-oss
[2020-05-05T20:06:39.648Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18262/src/github.com/elastic/beats/Auditbeat-crosscompile
[2020-05-05T20:06:39.948Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18262/src/github.com/elastic/beats/Metricbeat-Python-integration-tests
[2020-05-05T20:06:40.378Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18262/src/github.com/elastic/beats/Libbeat-oss
[2020-05-05T20:06:40.773Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18262/src/github.com/elastic/beats/Libbeat-crosscompile
[2020-05-05T20:06:41.120Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18262/src/github.com/elastic/beats/Heartbeat-Windows
[2020-05-05T20:06:41.520Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18262/src/github.com/elastic/beats/Libbeat-stress-tests
[2020-05-05T20:06:41.873Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18262/src/github.com/elastic/beats/Winlogbeat-Windows
[2020-05-05T20:06:42.156Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18262/src/github.com/elastic/beats/Generators-Beat-Linux
[2020-05-05T20:06:42.518Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18262/src/github.com/elastic/beats/Functionbeat-Windows
[2020-05-05T20:06:42.898Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18262/src/github.com/elastic/beats/Auditbeat-Windows
[2020-05-05T20:06:43.290Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18262/src/github.com/elastic/beats/Metricbeat-OSS-Integration-tests
[2020-05-05T20:06:43.631Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18262/src/github.com/elastic/beats/Metricbeat-x-pack
[2020-05-05T20:06:43.988Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18262/src/github.com/elastic/beats/Auditbeat-x-pack
[2020-05-05T20:06:44.870Z] + cat
[2020-05-05T20:06:44.870Z] + /usr/local/bin/runbld ./runbld-script
[2020-05-05T20:06:44.870Z] Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8
[2020-05-05T20:06:50.563Z] runbld>>> runbld started
[2020-05-05T20:06:50.563Z] runbld>>> 1.6.11/a66728ff8f4356963772e6e6d2069392fa06acbe
[2020-05-05T20:06:52.171Z] runbld>>> The following profiles matched the job 'Beats/beats-beats-mbp/PR-18262' in order of occurrence in the config (last value wins).
[2020-05-05T20:06:53.745Z] runbld>>> Debug logging enabled.
[2020-05-05T20:06:53.745Z] runbld>>> Storing result
[2020-05-05T20:06:53.745Z] runbld>>> Store result: created {:total 2, :successful 2, :failed 0} 1
[2020-05-05T20:06:53.745Z] runbld>>> BUILD: https://c150076387b5421f9154dfbf536e5c60.us-west1.gcp.cloud.es.io:9243/build-1587637540455/t/20200505200653-6350B6BC
[2020-05-05T20:06:53.745Z] runbld>>> Adding system facts.
[2020-05-05T20:06:54.826Z] runbld>>> Adding vcs info for the latest commit:  f6c6142f2bf13403b342ff82312ad648a291ac4c
[2020-05-05T20:06:54.826Z] runbld>>> >>>>>>>>>>>> SCRIPT EXECUTION BEGIN >>>>>>>>>>>>
[2020-05-05T20:06:54.826Z] runbld>>> Adding /usr/lib/jvm/java-8-openjdk-amd64/bin to the path.
[2020-05-05T20:06:54.826Z] Processing JUnit reports with runbld...
[2020-05-05T20:06:54.826Z] + echo 'Processing JUnit reports with runbld...'
[2020-05-05T20:06:55.489Z] runbld>>> <<<<<<<<<<<< SCRIPT EXECUTION END <<<<<<<<<<<<
[2020-05-05T20:06:55.489Z] runbld>>> DURATION: 16ms
[2020-05-05T20:06:55.489Z] runbld>>> STDOUT: 40 bytes
[2020-05-05T20:06:55.489Z] runbld>>> STDERR: 49 bytes
[2020-05-05T20:06:55.489Z] runbld>>> WRAPPED PROCESS: SUCCESS (0)
[2020-05-05T20:06:55.489Z] runbld>>> Searching for build metadata in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18262/src/github.com/elastic/beats
[2020-05-05T20:06:56.564Z] runbld>>> Storing build metadata: 
[2020-05-05T20:06:56.564Z] runbld>>> Adding test report.
[2020-05-05T20:06:56.564Z] runbld>>> Searching for junit test output files with the pattern: TEST-.*\.xml$ in: /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18262/src/github.com/elastic/beats
[2020-05-05T20:06:58.088Z] runbld>>> Found 91 test output files
[2020-05-05T20:06:58.424Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18262/src/github.com/elastic/beats/Metricbeat-x-pack/x-pack/metricbeat/build/TEST-go-integration-openmetrics.xml
[2020-05-05T20:06:58.425Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18262/src/github.com/elastic/beats/Metricbeat-x-pack/x-pack/metricbeat/build/TEST-go-integration-istio.xml
[2020-05-05T20:06:58.425Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18262/src/github.com/elastic/beats/Metricbeat-x-pack/x-pack/metricbeat/build/TEST-go-integration-iis.xml
[2020-05-05T20:06:58.425Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18262/src/github.com/elastic/beats/Metricbeat-x-pack/x-pack/metricbeat/build/TEST-go-integration-activemq.xml
[2020-05-05T20:06:58.425Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18262/src/github.com/elastic/beats/Metricbeat-x-pack/x-pack/metricbeat/build/TEST-go-integration-tomcat.xml
[2020-05-05T20:06:58.425Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18262/src/github.com/elastic/beats/Metricbeat-x-pack/x-pack/metricbeat/build/TEST-go-integration-cloudfoundry.xml
[2020-05-05T20:06:58.737Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18262/src/github.com/elastic/beats/Metricbeat-OSS-Integration-tests/metricbeat/build/TEST-go-integration-windows.xml
[2020-05-05T20:06:59.043Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18262/src/github.com/elastic/beats/Metricbeat-OSS-Integration-tests/metricbeat/build/TEST-go-integration-graphite.xml
[2020-05-05T20:06:59.381Z] runbld>>> Test output logs contained: Errors: 0 Failures: 0 Tests: 6565 Skipped: 700
[2020-05-05T20:06:59.381Z] runbld>>> Storing result
[2020-05-05T20:06:59.381Z] runbld>>> FAILURES: 0
[2020-05-05T20:06:59.683Z] runbld>>> Store result: updated {:total 2, :successful 2, :failed 0} 2
[2020-05-05T20:06:59.683Z] runbld>>> BUILD: https://c150076387b5421f9154dfbf536e5c60.us-west1.gcp.cloud.es.io:9243/build-1587637540455/t/20200505200653-6350B6BC
[2020-05-05T20:06:59.683Z] runbld>>> Email notification disabled by environment variable.
[2020-05-05T20:06:59.683Z] runbld>>> Slack notification disabled by environment variable.
[2020-05-05T20:07:08.612Z] Running on worker-395930 in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18262
[2020-05-05T20:07:09.230Z] [INFO] getVaultSecret: Getting secrets
[2020-05-05T20:07:09.444Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2020-05-05T20:07:12.622Z] + chmod 755 generate-build-data.sh
[2020-05-05T20:07:12.622Z] + ./generate-build-data.sh https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats-beats-mbp/PR-18262/ https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats-beats-mbp/PR-18262/runs/1 ABORTED 7537429
[2020-05-05T20:07:12.622Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats-beats-mbp/PR-18262/runs/1/steps/?limit=10000 -o steps-info.json
[2020-05-05T20:07:14.207Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats-beats-mbp/PR-18262/runs/1/tests/?status=FAILED -o tests-errors.json
[2020-05-05T20:07:15.781Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats-beats-mbp/PR-18262/runs/1/log/ -o pipeline-log.txt

@simitt
Copy link
Contributor Author

simitt commented May 5, 2020 •
edited
Loading

failing tests seem unrelated
no failed tests, reporting failed

@simitt simitt merged commit 2a85d6f into elastic:7.x May 5, 2020
@simitt simitt mentioned this pull request May 5, 2020
Merged
4 tasks
@simitt simitt deleted the backport/7.x/pr-17974 branch August 4, 2020 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ycombinator ycombinator ycombinator approved these changes

Assignees
No one assigned
Labels
backport needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simitt @elasticmachine @ycombinator