Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Heartbeat] Capture HTTP headers #18327

Merged
merged 6 commits into from
Jun 9, 2020
Merged

Conversation

andrewvc
Copy link
Contributor

@andrewvc andrewvc commented May 6, 2020

Provides progress toward: elastic/uptime#190

Captures HTTP headers and stores them in the response in the same manner
as APM Server, using canonical header names in http.response.headers.
Values are not indexed, just stored, in ES.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

How to test this PR locally

Run the default config

Provides progress toward: elastic/uptime#190

Captures HTTP headers and stores them in the response in the same manner
as APM Server, using canonical header names in `http.response.headers`.
Values are not indexed, just stored, in ES.
@andrewvc andrewvc added enhancement Heartbeat Team:obs-ds-hosted-services Label for the Observability Hosted Services team labels May 6, 2020
@andrewvc andrewvc requested a review from a team as a code owner May 6, 2020 21:10
@elasticmachine
Copy link
Collaborator

Pinging @elastic/uptime (Team:Uptime)

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 6, 2020
@andrewvc andrewvc removed the needs_team Indicates that the issue/PR needs a Team:* label label May 6, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented May 6, 2020

💔 Build Failed

Pipeline View Test View Changes Artifacts preview stats

Expand to view the summary

Build stats

  • Build Cause: [Branch indexing]

  • Start Time: 2020-05-08T14:51:17.870+0000

  • Duration: 122 min 26 sec (7346056)

  • Commit: de89675

Log output

Expand to view the last 100 lines of log output

[2020-05-08T16:04:03.159Z] + FILE=metricbeat/build/coverage/full.cov
[2020-05-08T16:04:03.159Z] + [ -f metricbeat/build/coverage/full.cov ]
[2020-05-08T16:04:03.159Z] + FILE=packetbeat/build/coverage/full.cov
[2020-05-08T16:04:03.159Z] + [ -f packetbeat/build/coverage/full.cov ]
[2020-05-08T16:04:03.159Z] + FILE=winlogbeat/build/coverage/full.cov
[2020-05-08T16:04:03.159Z] + [ -f winlogbeat/build/coverage/full.cov ]
[2020-05-08T16:04:03.159Z] + FILE=journalbeat/build/coverage/full.cov
[2020-05-08T16:04:03.159Z] + [ -f journalbeat/build/coverage/full.cov ]
[2020-05-08T16:04:08.061Z] Stage "Elastic Agent x-pack" skipped due to when conditional
[2020-05-08T16:04:08.062Z] Stage "Elastic Agent x-pack Windows" skipped due to when conditional
[2020-05-08T16:04:08.063Z] Stage "Elastic Agent Mac OS X" skipped due to when conditional
[2020-05-08T16:04:08.065Z] Stage "Filebeat oss" skipped due to when conditional
[2020-05-08T16:04:08.066Z] Stage "Filebeat x-pack" skipped due to when conditional
[2020-05-08T16:04:08.067Z] Stage "Filebeat Mac OS X" skipped due to when conditional
[2020-05-08T16:04:08.068Z] Stage "Filebeat Windows" skipped due to when conditional
[2020-05-08T16:04:08.070Z] Stage "Auditbeat oss" skipped due to when conditional
[2020-05-08T16:04:08.071Z] Stage "Auditbeat x-pack" skipped due to when conditional
[2020-05-08T16:04:08.073Z] Stage "Libbeat" skipped due to when conditional
[2020-05-08T16:04:08.073Z] Stage "Libbeat x-pack" skipped due to when conditional
[2020-05-08T16:04:08.077Z] Stage "Metricbeat OSS Unit tests" skipped due to when conditional
[2020-05-08T16:04:08.079Z] Stage "Metricbeat OSS Integration tests" skipped due to when conditional
[2020-05-08T16:04:08.082Z] Stage "Metricbeat Python integration tests" skipped due to when conditional
[2020-05-08T16:04:08.084Z] Stage "Metricbeat x-pack" skipped due to when conditional
[2020-05-08T16:04:08.085Z] Stage "Metricbeat crosscompile" skipped due to when conditional
[2020-05-08T16:04:08.086Z] Stage "Metricbeat Mac OS X" skipped due to when conditional
[2020-05-08T16:04:08.087Z] Stage "Metricbeat Windows" skipped due to when conditional
[2020-05-08T16:04:08.091Z] Stage "Packetbeat" skipped due to when conditional
[2020-05-08T16:04:08.092Z] Stage "dockerlogbeat" skipped due to when conditional
[2020-05-08T16:04:08.094Z] Stage "Winlogbeat" skipped due to when conditional
[2020-05-08T16:04:08.096Z] Stage "Winlogbeat Windows x-pack" skipped due to when conditional
[2020-05-08T16:04:08.097Z] Stage "Functionbeat" skipped due to when conditional
[2020-05-08T16:04:08.098Z] Stage "Journalbeat" skipped due to when conditional
[2020-05-08T16:04:08.100Z] Stage "Generators" skipped due to when conditional
[2020-05-08T16:04:08.100Z] Stage "Kubernetes" skipped due to when conditional
[2020-05-08T16:04:08.719Z] Stage "Auditbeat oss" skipped due to when conditional
[2020-05-08T16:04:08.720Z] Stage "Libbeat" skipped due to when conditional
[2020-05-08T16:04:08.721Z] Stage "Metricbeat x-pack" skipped due to when conditional
[2020-05-08T16:04:08.723Z] Stage "Packetbeat" skipped due to when conditional
[2020-05-08T16:04:08.724Z] Stage "dockerlogbeat" skipped due to when conditional
[2020-05-08T16:04:08.725Z] Stage "Winlogbeat" skipped due to when conditional
[2020-05-08T16:04:08.726Z] Stage "Functionbeat" skipped due to when conditional
[2020-05-08T16:04:08.727Z] Stage "Journalbeat" skipped due to when conditional
[2020-05-08T16:04:08.728Z] Stage "Generators" skipped due to when conditional
[2020-05-08T16:04:10.403Z] Stage "Auditbeat oss" skipped due to when conditional
[2020-05-08T16:04:10.405Z] Stage "Libbeat" skipped due to when conditional
[2020-05-08T16:04:10.407Z] Stage "Metricbeat x-pack" skipped due to when conditional
[2020-05-08T16:04:10.408Z] Stage "Winlogbeat" skipped due to when conditional
[2020-05-08T16:04:10.409Z] Stage "Functionbeat" skipped due to when conditional
[2020-05-08T16:04:10.410Z] Stage "Generators" skipped due to when conditional
[2020-05-08T16:04:11.447Z] Stage "Auditbeat oss" skipped due to when conditional
[2020-05-08T16:04:11.448Z] Stage "Libbeat" skipped due to when conditional
[2020-05-08T16:04:11.449Z] Stage "Functionbeat" skipped due to when conditional
[2020-05-08T16:04:11.450Z] Stage "Generators" skipped due to when conditional
[2020-05-08T16:04:12.113Z] Stage "Auditbeat oss" skipped due to when conditional
[2020-05-08T16:04:12.115Z] Stage "Generators" skipped due to when conditional
[2020-05-08T16:04:23.496Z] Still waiting to schedule task
[2020-05-08T16:04:23.496Z] Waiting for next available executor on ‘ubuntu&&immutable’
[2020-05-08T16:53:20.861Z] Cancelling nested steps due to timeout
[2020-05-08T16:53:21.020Z] Failed in branch Heartbeat
[2020-05-08T16:53:21.331Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18327/src/github.com/elastic/beats
[2020-05-08T16:53:21.847Z] + find . -type f -name TEST*.xml -path */build/* -delete
[2020-05-08T16:53:21.921Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18327/src/github.com/elastic/beats/Lint
[2020-05-08T16:53:22.971Z] + cat
[2020-05-08T16:53:22.971Z] + /usr/local/bin/runbld ./runbld-script
[2020-05-08T16:53:22.971Z] Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8
[2020-05-08T16:53:29.971Z] runbld>>> runbld started
[2020-05-08T16:53:29.971Z] runbld>>> 1.6.11/a66728ff8f4356963772e6e6d2069392fa06acbe
[2020-05-08T16:53:30.827Z] runbld>>> The following profiles matched the job 'Beats/beats-beats-mbp/PR-18327' in order of occurrence in the config (last value wins).
[2020-05-08T16:53:32.173Z] runbld>>> Debug logging enabled.
[2020-05-08T16:53:32.173Z] runbld>>> Storing result
[2020-05-08T16:53:32.559Z] runbld>>> Store result: created {:total 2, :successful 2, :failed 0} 1
[2020-05-08T16:53:32.559Z] runbld>>> BUILD: https://c150076387b5421f9154dfbf536e5c60.us-west1.gcp.cloud.es.io:9243/build-1587637540455/t/20200508165332-E86CAC30
[2020-05-08T16:53:32.559Z] runbld>>> Adding system facts.
[2020-05-08T16:53:33.257Z] runbld>>> Adding vcs info for the latest commit:  7353c49d12a22a7915cb8549c5d0265be8ffba33
[2020-05-08T16:53:33.583Z] runbld>>> >>>>>>>>>>>> SCRIPT EXECUTION BEGIN >>>>>>>>>>>>
[2020-05-08T16:53:33.583Z] runbld>>> Adding /usr/lib/jvm/java-8-openjdk-amd64/bin to the path.
[2020-05-08T16:53:33.583Z] Processing JUnit reports with runbld...
[2020-05-08T16:53:33.583Z] + echo 'Processing JUnit reports with runbld...'
[2020-05-08T16:53:33.929Z] runbld>>> <<<<<<<<<<<< SCRIPT EXECUTION END <<<<<<<<<<<<
[2020-05-08T16:53:33.929Z] runbld>>> DURATION: 13ms
[2020-05-08T16:53:33.929Z] runbld>>> STDOUT: 40 bytes
[2020-05-08T16:53:33.929Z] runbld>>> STDERR: 49 bytes
[2020-05-08T16:53:33.929Z] runbld>>> WRAPPED PROCESS: SUCCESS (0)
[2020-05-08T16:53:33.929Z] runbld>>> Searching for build metadata in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18327/src/github.com/elastic/beats
[2020-05-08T16:53:35.108Z] runbld>>> Storing build metadata: 
[2020-05-08T16:53:35.108Z] runbld>>> Adding test report.
[2020-05-08T16:53:35.108Z] runbld>>> Searching for junit test output files with the pattern: TEST-.*\.xml$ in: /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18327/src/github.com/elastic/beats
[2020-05-08T16:53:36.218Z] runbld>>> Found 0 test output files
[2020-05-08T16:53:36.218Z] runbld>>> Test output logs contained: Errors: 0 Failures: 0 Tests: 0 Skipped: 0
[2020-05-08T16:53:36.561Z] runbld>>> Storing result
[2020-05-08T16:53:36.561Z] runbld>>> Store result: updated {:total 2, :successful 2, :failed 0} 2
[2020-05-08T16:53:36.561Z] runbld>>> BUILD: https://c150076387b5421f9154dfbf536e5c60.us-west1.gcp.cloud.es.io:9243/build-1587637540455/t/20200508165332-E86CAC30
[2020-05-08T16:53:36.561Z] runbld>>> Email notification disabled by environment variable.
[2020-05-08T16:53:36.561Z] runbld>>> Slack notification disabled by environment variable.
[2020-05-08T16:53:42.657Z] Running on Jenkins in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18327
[2020-05-08T16:53:42.905Z] [INFO] getVaultSecret: Getting secrets
[2020-05-08T16:53:43.062Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2020-05-08T16:53:44.308Z] + chmod 755 generate-build-data.sh
[2020-05-08T16:53:44.308Z] + ./generate-build-data.sh https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats-beats-mbp/PR-18327/ https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats-beats-mbp/PR-18327/runs/3 ABORTED 7346056
[2020-05-08T16:53:44.860Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats-beats-mbp/PR-18327/runs/3/steps/?limit=10000 -o steps-info.json

@andrewvc
Copy link
Contributor Author

jenkins, test this please

@elasticmachine
Copy link
Collaborator

elasticmachine commented Jun 4, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #18327 updated]

  • Start Time: 2020-06-05T02:21:17.400+0000

  • Duration: 63 min 27 sec

Test stats 🧪

Test Results
Failed 0
Passed 1120
Skipped 140
Total 1260

Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Sorry for the delayed review!

@andrewvc andrewvc merged commit af4ebe5 into elastic:master Jun 9, 2020
@andrewvc andrewvc deleted the store-http-headers branch June 9, 2020 01:16
@andrewvc andrewvc added the v7.9.0 label Jun 9, 2020
andrewvc added a commit to andrewvc/beats that referenced this pull request Jun 9, 2020
Provides progress toward: elastic/uptime#190

Captures HTTP headers and stores them in the response in the same manner
as APM Server, using canonical header names in `http.response.headers`.
Values are not indexed, just stored, in ES.

(cherry picked from commit af4ebe5)
andrewvc added a commit that referenced this pull request Jun 9, 2020
Provides progress toward: elastic/uptime#190

Captures HTTP headers and stores them in the response in the same manner
as APM Server, using canonical header names in `http.response.headers`.
Values are not indexed, just stored, in ES.

(cherry picked from commit af4ebe5)
melchiormoulin pushed a commit to melchiormoulin/beats that referenced this pull request Oct 14, 2020
Provides progress toward: elastic/uptime#190

Captures HTTP headers and stores them in the response in the same manner
as APM Server, using canonical header names in `http.response.headers`.
Values are not indexed, just stored, in ES.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Heartbeat Team:obs-ds-hosted-services Label for the Observability Hosted Services team v7.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants