Cherry-pick #18340 to 7.8: [Winlogbeat] Add support for FileDelete events (event id 23) to sysmon module #18363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stic#18340) FileDelete events were added in Sysmon v11. Prior to this change processing such events lead to an 'unexpected sysmon event_id' error message. Closes elastic#18094 (cherry picked from commit 0a327bb)
botelastic
bot
added
the
needs_team
andrewkroh
added
Team:SIEM
and removed
needs_team
|
Pinging @elastic/siem (Team:SIEM) |
andrewkroh
added
needs_team
kaiyan-sheng
approved these changes
May 7, 2020
andrewstucki
approved these changes
May 7, 2020
There was a problem hiding this comment.
Apart from my one comment which we can do in a follow up PR to the 7.x branch (along with the other changes you suggested in #18340) LGTM
| "pid": 776 | ||
| }, | ||
| "rule": { | ||
| "name": "-" |
There was a problem hiding this comment.
We might want to consider dropping this field if it doesn't actually contain anything valuable
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #18340 to 7.8 branch. Original message:
What does this PR do?
FileDelete events were added in Sysmon v11, this PR adds support for FileDelete events (event id 23) to sysmon module.
Why is it important?
Prior to this change processing such events lead to an 'unexpected sysmon event_id' error message.
Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration filesCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.TODO
Empty strings are replaced with “-“ to work around a WEF bugRelated issues
Closes #18094