Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #18340 to 7.x: [Winlogbeat] Add support for FileDelete events (event id 23) to sysmon module #18371

Merged
merged 1 commit into from
May 8, 2020

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented May 8, 2020

Cherry-pick of PR #18340 to 7.x branch. Original message:

What does this PR do?

FileDelete events were added in Sysmon v11, this PR adds support for FileDelete events (event id 23) to sysmon module.

Why is it important?

Prior to this change processing such events lead to an 'unexpected sysmon event_id' error message.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

TODO

  • Diff the schema XML from v10 to v11 and make updates.
  • Empty strings are replaced with “-“ to work around a WEF bug
  • Handle Event ID 23
  • Add .evtx test files from v11.

Related issues

Closes #18094

…stic#18340)

FileDelete events were added in Sysmon v11.
Prior to this change processing such events lead to an 'unexpected sysmon event_id' error message.

Closes elastic#18094

(cherry picked from commit 0a327bb)
@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 8, 2020
@marc-gr marc-gr removed the needs_team Indicates that the issue/PR needs a Team:* label label May 8, 2020
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview stats

Expand to view the summary

Build stats

Test stats 🧪

Test Results
Failed 0
Passed 263
Skipped 1
Total 264

@marc-gr marc-gr merged commit c4c1193 into elastic:7.x May 8, 2020
@marc-gr marc-gr deleted the backport_18340_7.x branch May 8, 2020 13:18
@marc-gr marc-gr restored the backport_18340_7.x branch May 14, 2020 13:15
@marc-gr marc-gr deleted the backport_18340_7.x branch May 14, 2020 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants