Fix bdist during installation of Python requirements #18745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
cachedout
changed the title
❕ Build Aborted
Expand to view the summary
Build stats
Test stats 🧪
Test errorsExpand to view the tests failures
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
mdelapenya
reviewed
May 26, 2020
mdelapenya
approved these changes
May 26, 2020
mdelapenya
added
the
Team:Automation
botelastic
bot
removed
the
needs_team
kuisathaverat
approved these changes
May 26, 2020
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
|
Hi @andrewkroh . I was hoping this might be something you could take a look at. Any chance you could weigh in when you have a moment? Thanks! |
andrewkroh
reviewed
Jun 4, 2020
Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
Hi @andrewkroh . I looked through the logs from this test run and couldn't detect any failures related to bdist or wheel. The failure on APM server is somewhat transient so verifying this fix prior to merging it might prove challenging. Are you opposed to merging this as-is and seeing how things look on the APM Server CI job over the next 1-2 weeks? |
marc-gr
pushed a commit
to marc-gr/beats
that referenced
this pull request
Jul 14, 2020
* Fix bdist/wheel errors on build * Use independent args * Formatting * Remove -r * Collapse into single line * Update dev-tools/mage/pytest.go Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co> Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co> (cherry picked from commit 10a2ce9)
6 tasks
andrewkroh
pushed a commit
that referenced
this pull request
Jul 14, 2020
* Fix bdist/wheel errors on build * Use independent args * Formatting * Remove -r * Collapse into single line * Update dev-tools/mage/pytest.go Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co> (cherry picked from commit 10a2ce9) Co-authored-by: cachedout <mike.place@elastic.co>
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
* Fix bdist/wheel errors on build * Use independent args * Formatting * Remove -r * Collapse into single line * Update dev-tools/mage/pytest.go Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co> Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR addresses an issue in the build system which produces errors similar to the following:
Note that these errors are from the APM CI where they have been discovered in builds for the APM Server project but the source of the errors appears to stem from libbeat.
A full discussion and background on this issue can be found here: elastic/apm-server#3661
Cause and resolution
I believe this may have been introduced during the migration to Python 3 but I don't have a test history that goes back far enough to confirm this.
This is a difficult-to-reproduce problem and I have yet to be able to do so locally. However, it seems clear that the issue is that the
wheelPython package needs to be present in order for the wheels to be created. This fix attempts to simply simply tellpipto installwheelinto the newly-created virtual environment before it proceeds with installing packages from the requirements file.Why is it important?
Fixes errors found in the CI on package which depend on
libbeat.Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature worksI have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.How to test this PR locally
I haven't found a way to just run the
PythonVirtualenvtarget with mage but I did runmage pythonUnitTestwhich does seem to exercise this code path.Related issues