-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add check on <no value>
config option value for the azure input resource_manager_endpoint
#18890
Conversation
Pinging @elastic/integrations (Team:Integrations) |
💚 Build SucceededExpand to view the summary
Build stats
Test stats 🧪
Steps errorsExpand to view the steps failures
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add documentation on <no value>
?
I don't think so, this happens only when we ignore/don't set this configuration option in the azure filebeat module. |
…source_manager_endpoint` (elastic#18890) * change * update changelog (cherry picked from commit 8dda6e1)
…source_manager_endpoint` (elastic#18890) * change * update changelog (cherry picked from commit 8dda6e1)
…source_manager_endpoint` (elastic#18890) * change * update changelog
What does this PR do?
Adds a check on
<no value>
config option value for the azure inputresource_manager_endpoint
Updates test.
Why is it important?
Seems that after some recent changes, if a value is not set for
resource_manager_endpoint
then the value<no value>
is sent to the input config. This needs to be checked at the input level.Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.How to test this PR locally
Do not set a value for
resource_manager_endpoint
when running the azure module in filebeat, no events will be generated and logs will provide more information on the error regarding the azure env.