Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check on <no value> config option value for the azure input resource_manager_endpoint #18890

Merged
merged 4 commits into from
Jun 4, 2020

Conversation

narph
Copy link
Contributor

@narph narph commented Jun 2, 2020

What does this PR do?

Adds a check on <no value> config option value for the azure input resource_manager_endpoint
Updates test.

Why is it important?

Seems that after some recent changes, if a value is not set for resource_manager_endpoint then the value <no value> is sent to the input config. This needs to be checked at the input level.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

Do not set a value for resource_manager_endpoint when running the azure module in filebeat, no events will be generated and logs will provide more information on the error regarding the azure env.

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 2, 2020
@narph narph self-assigned this Jun 2, 2020
@narph narph added [zube]: In Review Team:Integrations Label for the Integrations team labels Jun 2, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jun 2, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jun 2, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #18890 updated]

  • Start Time: 2020-06-04T12:33:42.737+0000

  • Duration: 52 min 53 sec

Test stats 🧪

Test Results
Failed 0
Passed 2226
Skipped 382
Total 2608

Steps errors

Expand to view the steps failures

  • Name: Report to Codecov

    • Description: curl -sSLo codecov https://codecov.io/bash for i in auditbeat filebeat heartbeat libbeat metricbeat packetbeat winlogbeat journalbeat do FILE="${i}/build/coverage/full.cov" if [ -f "${FILE}" ]; then bash codecov -f "${FILE}" fi done

    • Duration: 2 min 22 sec

    • Start Time: 2020-06-04T12:55:45.039+0000

    • log

  • Name: Report to Codecov

    • Description: curl -sSLo codecov https://codecov.io/bash for i in auditbeat filebeat heartbeat libbeat metricbeat packetbeat winlogbeat journalbeat do FILE="${i}/build/coverage/full.cov" if [ -f "${FILE}" ]; then bash codecov -f "${FILE}" fi done

    • Duration: 2 min 22 sec

    • Start Time: 2020-06-04T13:22:49.920+0000

    • log

Copy link
Contributor

@kaiyan-sheng kaiyan-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add documentation on <no value>?

@narph
Copy link
Contributor Author

narph commented Jun 3, 2020

@kaiyan-sheng

Should we add documentation on <no value>?

I don't think so, this happens only when we ignore/don't set this configuration option in the azure filebeat module.
Instead of empty string, it is somehow translated in the azure-eventhub input to <no value>.
This seems to be a new behavior, not sure when it was introduced.

@narph narph requested a review from kaiyan-sheng June 3, 2020 12:01
@narph narph added the needs_backport PR is waiting to be backported to other branches. label Jun 4, 2020
@narph narph merged commit 8dda6e1 into elastic:master Jun 4, 2020
@narph narph deleted the azure-input-change branch June 4, 2020 14:15
narph added a commit to narph/beats that referenced this pull request Jun 24, 2020
…source_manager_endpoint` (elastic#18890)

* change

* update changelog

(cherry picked from commit 8dda6e1)
narph added a commit to narph/beats that referenced this pull request Jun 24, 2020
…source_manager_endpoint` (elastic#18890)

* change

* update changelog

(cherry picked from commit 8dda6e1)
narph added a commit that referenced this pull request Jun 25, 2020
…lue for the azure input `resource_manager_endpoint` (#19351)

* Add check on `<no value>` config option value for the azure input `resource_manager_endpoint` (#18890)

* change

* update changelog

(cherry picked from commit 8dda6e1)

* fix
narph added a commit that referenced this pull request Jun 25, 2020
…source_manager_endpoint` (#18890) (#19352)

* change

* update changelog

(cherry picked from commit 8dda6e1)
melchiormoulin pushed a commit to melchiormoulin/beats that referenced this pull request Oct 14, 2020
…source_manager_endpoint` (elastic#18890)

* change

* update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs_backport PR is waiting to be backported to other branches. Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants