Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix metricsets in gcp module to use new stackdriver config format #18985

Merged
merged 1 commit into from
Jun 5, 2020
Merged

Fix metricsets in gcp module to use new stackdriver config format #18985

merged 1 commit into from
Jun 5, 2020

Conversation

kaiyan-sheng
Copy link
Contributor

This is a followup PR for #18691 to fix all metricsets under googlecloud module to use new stackdriver config format.

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 4, 2020
@kaiyan-sheng kaiyan-sheng self-assigned this Jun 4, 2020
@kaiyan-sheng kaiyan-sheng added needs_backport PR is waiting to be backported to other branches. review Team:Platforms Label for the Integrations - Platforms team labels Jun 4, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jun 4, 2020
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #18985 opened]

  • Start Time: 2020-06-04T19:59:55.890+0000

  • Duration: 76 min 8 sec

Test stats 🧪

Test Results
Failed 0
Passed 1228
Skipped 199
Total 1427

ChrsMark
ChrsMark approved these changes Jun 5, 2020
View reviewed changes
Copy link
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kaiyan-sheng kaiyan-sheng merged commit 7a64ad4 into elastic:master Jun 5, 2020
@kaiyan-sheng kaiyan-sheng deleted the fix_gcp branch June 5, 2020 13:55
@kaiyan-sheng kaiyan-sheng mentioned this pull request Jun 6, 2020
Merged
@kaiyan-sheng kaiyan-sheng added v7.9.0 and removed needs_backport PR is waiting to be backported to other branches. labels Jun 6, 2020
kaiyan-sheng added a commit that referenced this pull request Jun 12, 2020
@kaiyan-sheng
Fix metricsets in googlecloud module to use new stackdriver config fo…
bb503f8 
…rmat (#18985) (#19024)

(cherry picked from commit 7a64ad4)
melchiormoulin pushed a commit to melchiormoulin/beats that referenced this pull request Oct 14, 2020
@kaiyan-sheng @melchiormoulin
Fix metricsets in googlecloud module to use new stackdriver config fo…
6ec8d07 
…rmat (elastic#18985)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrsMark ChrsMark ChrsMark approved these changes

Assignees

@kaiyan-sheng kaiyan-sheng

Labels
review Team:Platforms Label for the Integrations - Platforms team v7.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kaiyan-sheng @elasticmachine @ChrsMark @andresrc