Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #18967 to 7.x: Moved from stream to dataset #19093

Merged
merged 1 commit into from
Jun 12, 2020

Conversation

michalpristas
Copy link
Contributor

Cherry-pick of PR #18967 to 7.x branch. Original message:

What does this PR do?

Changes injected processor to events so it enriches them with dataset.* instead of stream.*

Why is it important?

elastic/package-registry#491

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

As draft until we are ready and in sync to merge

Fixes: elastic/package-registry#491
Fixes: #18826

cc @ruflin

[Ingest Manager] Moved from stream to dataset (elastic#18967)
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jun 10, 2020
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #19093 opened]

  • Start Time: 2020-06-10T09:30:40.006+0000

  • Duration: 34 min 21 sec

Copy link
Member

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Did not test it locally but assume it is a 1 to 1 cherry pick.

@michalpristas michalpristas merged commit 44fe1fb into elastic:7.x Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport enhancement Ingest Management:beta1 Group issues for ingest management beta1 review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants